Re: [PATCH 09/58] move cobalt-lcd's probe function to .devinit.text

Ralf Baechle
2009-03-28T10:44:43Z

On Sat, Mar 28, 2009 at 12:26:30AM +0100, Uwe Kleine-König wrote:

> A pointer to cobalt_lcdfb_probe is passed to the core via
> platform_driver_register and so the function must not disappear when the
> .init sections are discarded. Otherwise (if also having HOTPLUG=y)
> unbinding and binding a device to the driver via sysfs will result in an
> oops as does a device being registered late.
>
> An alternative to this patch is using platform_driver_probe instead of
> platform_driver_register plus removing the pointer to the probe function
> from the struct platform_driver.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
> Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>
> Cc: Antonino Daplas <adaplas@pol.net>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>

Acked-by: Ralf Baechle <ralf@linux-mips.org>

Ralf