Re: [PATCH 39/58] move r8a66597_hcd's probe function to .devinit.text

Yoshihiro Shimoda
2009-03-30T02:27:57Z

Acked-by: Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com>

Thanks,
Yoshihiro Shimoda

Uwe Kleine-König wrote:
> A pointer to r8a66597_probe is passed to the core via
> platform_driver_register and so the function must not disappear when the
> .init sections are discarded. Otherwise (if also having HOTPLUG=y)
> unbinding and binding a device to the driver via sysfs will result in an
> oops as does a device being registered late.
>
> An alternative to this patch is using platform_driver_probe instead of
> platform_driver_register plus removing the pointer to the probe function
> from the struct platform_driver.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Cc: Magnus Damm <damm@igel.co.jp>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Paul Mundt <lethal@linux-sh.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> ---
> drivers/usb/host/r8a66597-hcd.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/r8a66597-hcd.c b/drivers/usb/host/r8a66597-hcd.c
> index f1626e5..3e1216a 100644
> --- a/drivers/usb/host/r8a66597-hcd.c
> +++ b/drivers/usb/host/r8a66597-hcd.c
> @@ -2373,7 +2373,7 @@ static int __init_or_module r8a66597_remove(struct platform_device *pdev)
> return 0;
> }
>
> -static int __init r8a66597_probe(struct platform_device *pdev)
> +static int __devinit r8a66597_probe(struct platform_device *pdev)
> {
> #if defined(CONFIG_SUPERH_ON_CHIP_R8A66597) && defined(CONFIG_HAVE_CLK)
> char clk_name[8];