Re: [PATCH 34/58] move omap_rng's probe function to .devinit.text

David Brownell
2009-03-29T19:10:40Z

On Sunday 29 March 2009, Herbert Xu wrote:
> On Sat, Mar 28, 2009 at 12:26:55AM +0100, Uwe Kleine-König wrote:
> > A pointer to omap_rng_probe is passed to the core via
> > platform_driver_register and so the function must not disappear when the
> > .init sections are discarded. Otherwise (if also having HOTPLUG=y)
> > unbinding and binding a device to the driver via sysfs will result in an
> > oops as does a device being registered late.
> >
> > An alternative to this patch is using platform_driver_probe instead of
> > platform_driver_register plus removing the pointer to the probe function
> > from the struct platform_driver.

Reminder: we're expecting such an updated version,
to replace this one.

> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> > Cc: David Brownell <dbrownell@users.sourceforge.net>
> > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > Cc: Patrick McHardy <kaber@trash.net>
> > Cc: Jan Engelhardt <jengelh@gmx.de>
> > Cc: Michael Buesch <mb@bu3sch.de>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
>
> Applied to cryptodev. Thanks!
> --
> Visit Openswan at http://www.openswan.org/
> Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
>
>