Re: [PATCH 47/58] move sharpsl-pm's probe function to .devinit.text

Eric Miao
2009-03-28T09:32:19Z

2009/3/28 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> A pointer to sharpsl_pm_probe is passed to the core via
> platform_driver_register and so the function must not disappear when the
> .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
> unbinding and binding a device to the driver via sysfs will result in an
> oops as does a device being registered late.
>
> An alternative to this patch is using platform_driver_probe instead of
> platform_driver_register plus removing the pointer to the probe function
> from the struct platform_driver.
>

This one looks OK to me.

> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Dmitry Baryshkov <dbaryshkov@gmail.com>
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Cc: Eric Miao <eric.miao@marvell.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> ---
>  arch/arm/common/sharpsl_pm.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/common/sharpsl_pm.c b/arch/arm/common/sharpsl_pm.c
> index 780bbf7..e88c9ca 100644
> --- a/arch/arm/common/sharpsl_pm.c
> +++ b/arch/arm/common/sharpsl_pm.c
> @@ -780,7 +780,7 @@ static struct platform_suspend_ops sharpsl_pm_ops = {
>  };
>  #endif
>
> -static int __init sharpsl_pm_probe(struct platform_device *pdev)
> +static int __devinit sharpsl_pm_probe(struct platform_device *pdev)
>  {
>        int ret;
>
> --
> 1.6.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

--
Cheers
- eric