Re: [PATCH 29/58] move omap24xxcam's probe function to .devinit.text

Sakari Ailus
2009-04-01T07:42:07Z

ext Uwe Kleine-König wrote:
> A pointer to omap24xxcam_probe is passed to the core via
> platform_driver_register and so the function must not disappear when the
> .init sections are discarded. Otherwise (if also having HOTPLUG=y)
> unbinding and binding a device to the driver via sysfs will result in an
> oops as does a device being registered late.
>
> An alternative to this patch is using platform_driver_probe instead of
> platform_driver_register plus removing the pointer to the probe function
> from the struct platform_driver.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Sakari Ailus <sakari.ailus@nokia.com>
> Cc: Trilok Soni <soni.trilok@gmail.com>
> Cc: Hans Verkuil <hverkuil@xs4all.nl>
> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> ---
> drivers/media/video/omap24xxcam.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

Signed-off-by: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>

--
Sakari Ailus
sakari.ailus@maxwell.research.nokia.com