Re: [PATCH 47/58] move sharpsl-pm's probe function to .devinit.text

Uwe Kleine-König
2009-03-28T19:38:53Z

On Sat, Mar 28, 2009 at 05:32:02PM +0800, Eric Miao wrote:
> 2009/3/28 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> > A pointer to sharpsl_pm_probe is passed to the core via
> > platform_driver_register and so the function must not disappear when the
> > .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
> > unbinding and binding a device to the driver via sysfs will result in an
> > oops as does a device being registered late.
> >
> > An alternative to this patch is using platform_driver_probe instead of
> > platform_driver_register plus removing the pointer to the probe function
> > from the struct platform_driver.
> >
>
> This one looks OK to me.
I assume this is an Acked-by: you?

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |