Re: [PATCH 04/58] move at91_ether's probe function to .devinit.text

Uwe Kleine-König
2009-03-28T06:32:30Z

Hi David,

On Fri, Mar 27, 2009 at 05:09:37PM -0700, David Brownell wrote:
> On Friday 27 March 2009, Uwe Kleine-König wrote:
> > An alternative to this patch is using platform_driver_probe instead of
> > platform_driver_register plus removing the pointer to the probe function
> > from the struct platform_driver.
>
> IMO that's preferable for this driver. There's no
> point in doing anything other than discarding the
> probe() method after the driver has been set up;
> it'd be doing nothing except wasting memory.
>
> Same thing for ... pretty much all other drivers
> for SoC platform devices.
>
> In this series, you cc'd me on four OMAP drivers
> (mmci-omap, mmci-omap-hs, omap-rng, omap_udc) which
> I *know* that's a completely workable -- and far
> preferable -- solution. There might be others.
So if I convert them to the alternative fix, you volunteer to test these
patches? (Or at least provide your Tested-and-Acked-by:?)

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |