From: Ingo Molnar <mingo@elte.hu>
To: "Michael K. Johnson" <johnsonm@rpath.com>
Cc: jmforbes@linuxtx.org, hpa@zytor.com, Jordan_Hargrave@Dell.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mark %esi as clobbered in E820 BIOS call
Date: Sat, 28 Mar 2009 12:20:35 +0100 [thread overview]
Message-ID: <20090328112035.GA11146@elte.hu> (raw)
In-Reply-To: <20090327171441.GD4363@logo.rdu.rpath.com>
* Michael K. Johnson <johnsonm@rpath.com> wrote:
> Justin and Peter, please review this for stable .y trees. Peter,
> please review this for trunk unless you decide to do a more
> extensive workaround for BIOS register clobbering.
>
> Thanks!
>
> $ cat e820-esi-clobber-workaround.patch
> Jordan Hargrave diagnosed a BIOS clobbering %esi in the E820 call.
> That particular BIOS has been fixed, but there is a possibility that
> this is responsible for other occasional reports of early boot
> failure, and it does not hurt to add %esi to the clobbers.
nice fix! Would you mind to update the clobber list to include _all_
registers? I dont see why any of the other registers couldnt be
clobbered by a BIOS, and this is boot-only code so micro-performance
is not an issue.
Ingo
next prev parent reply other threads:[~2009-03-28 11:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 17:14 [PATCH] mark %esi as clobbered in E820 BIOS call Michael K. Johnson
2009-03-28 11:20 ` Ingo Molnar [this message]
2009-03-28 19:18 ` H. Peter Anvin
2009-04-01 16:40 ` [GIT PULL] x86 setup BIOS workarounds H. Peter Anvin
2009-04-01 18:24 ` Linus Torvalds
2009-04-01 18:51 ` H. Peter Anvin
2009-04-02 4:26 ` Len Brown
2009-04-02 19:31 ` Linus Torvalds
2009-04-02 4:15 ` Len Brown
2009-04-02 20:07 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090328112035.GA11146@elte.hu \
--to=mingo@elte.hu \
--cc=Jordan_Hargrave@Dell.com \
--cc=hpa@zytor.com \
--cc=jmforbes@linuxtx.org \
--cc=johnsonm@rpath.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox