Re: [PATCH 0/7] Support for GB pages in KVM

Avi Kivity
2009-03-29T12:02:04Z

Marcelo Tosatti wrote:
> On Fri, Mar 27, 2009 at 03:31:52PM +0100, Joerg Roedel wrote:
>
>> Hi,
>>
>> this patchset extends the KVM MMU implementation to support 1GB pages as
>> supported by AMD family 16 processors. These patches enable support for
>> 1 GB pages with Nested Paging. Support for these pages in the shadow
>> paging code was also developed but does not run stable yet. The patch
>> for shadow-paging support is not included in this series and will be
>> sent out seperatly.
>>
>
> Looks generally sane. I'm not sure its even worthwhile to support
> GBpages with softmmu, because the chance of finding an area without
> shadowed (write protected) pages is much smaller than with 2MB pages.
>

If the guest uses 1GB pages in userspace, then these pages would not
have any write protected subpages.

--
error compiling committee.c: too many arguments to function