Re: [PATCH 7/7] kvm x86: report 1GB page support to userspace

Joerg Roedel
2009-03-29T12:55:07Z

On Sun, Mar 29, 2009 at 03:49:11PM +0300, Avi Kivity wrote:
> Joerg Roedel wrote:
>>>> int (*set_tss_addr)(struct kvm *kvm, unsigned int addr);
>>>> int (*get_tdp_level)(void);
>>>> int (*get_mt_mask_shift)(void);
>>>> +
>>>> + bool (*gb_page_enable)(void);
>>>> };
>>>>
>>> Should enable unconditionally. Of course we need to find the shadow
>>> bug first, may be the has_wrprotected thingy.
>>>
>>
>> This was the original plan. But how about VMX with EPT enabled? I am not
>> sure but I think this configuration will not support gbpages?
>>
>>
>
> You're right. Let's have a ->max_host_page_level() to handle that.
> It's 0.5T pages ready, too.

Ok I will change that together with the page_size -> page_level
chhanges. But I doubt that there will ever be 0.5T pages ;)

Joerg