Re: [PATCH 2/7] kvm mmu: infrastructure changes for multiple huge page support

Avi Kivity
2009-03-29T11:39:03Z

Joerg Roedel wrote:
> This patch includes most of the necessary changes to the KVM SoftMMU for
> supporting more than one huge page size. The changes in this patch
> include:
>
> * introduce 'enum kvm_page_size' which is used to represent the page
> size used
>

How about the concept of page_level instead, which returns the level of
a page in terms of the paging hierarchy? Would be easier to compare
against in the various walkers.

I've been thinking for a while to make levels zero-based, so 0 would be
a 4K page, 1 a 2M page, and 2 a 1GB page.

--
error compiling committee.c: too many arguments to function