* [PATCH] oprofile: Thou shalt not call __exit functions from __init functions
@ 2009-03-29 16:12 Russell King
2009-03-30 0:17 ` Rusty Russell
0 siblings, 1 reply; 3+ messages in thread
From: Russell King @ 2009-03-29 16:12 UTC (permalink / raw)
To: Rusty Russell; +Cc: oprofile-list, linux-kernel
`buffer_sync_cleanup' referenced in section `.init.text' of arch/arm/oprofile/built-in.o: defined in discarded section `.exit.text' of arch/arm/oprofile/built-in.o
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
drivers/oprofile/buffer_sync.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/oprofile/buffer_sync.c b/drivers/oprofile/buffer_sync.c
index c3ea5fa..2c9aa49 100644
--- a/drivers/oprofile/buffer_sync.c
+++ b/drivers/oprofile/buffer_sync.c
@@ -574,7 +574,7 @@ int __init buffer_sync_init(void)
return 0;
}
-void __exit buffer_sync_cleanup(void)
+void buffer_sync_cleanup(void)
{
free_cpumask_var(marked_cpus);
}
--
Russell King
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] oprofile: Thou shalt not call __exit functions from __init functions
2009-03-29 16:12 [PATCH] oprofile: Thou shalt not call __exit functions from __init functions Russell King
@ 2009-03-30 0:17 ` Rusty Russell
2009-03-31 11:49 ` Robert Richter
0 siblings, 1 reply; 3+ messages in thread
From: Rusty Russell @ 2009-03-30 0:17 UTC (permalink / raw)
To: Russell King; +Cc: oprofile-list, linux-kernel
On Monday 30 March 2009 02:42:22 Russell King wrote:
> `buffer_sync_cleanup' referenced in section `.init.text' of arch/arm/oprofile/built-in.o: defined in discarded section `.exit.text' of arch/arm/oprofile/built-in.o
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Thanks, I've applied it in case the oprofile people don't get there first.
Cheers,
Rusty.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] oprofile: Thou shalt not call __exit functions from __init functions
2009-03-30 0:17 ` Rusty Russell
@ 2009-03-31 11:49 ` Robert Richter
0 siblings, 0 replies; 3+ messages in thread
From: Robert Richter @ 2009-03-31 11:49 UTC (permalink / raw)
To: Rusty Russell; +Cc: Russell King, oprofile-list, linux-kernel
On 30.03.09 10:47:27, Rusty Russell wrote:
> On Monday 30 March 2009 02:42:22 Russell King wrote:
> > `buffer_sync_cleanup' referenced in section `.init.text' of arch/arm/oprofile/built-in.o: defined in discarded section `.exit.text' of arch/arm/oprofile/built-in.o
> >
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
There is patch 4c50d9ea9ca9e46b65aeffed3e0d6f54ff38c8d4 in
tip/cpus4096 that reworks and fixes this code already. It should go
upstream too.
-Robert
>
> Thanks, I've applied it in case the oprofile people don't get there first.
>
> Cheers,
> Rusty.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-03-31 11:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-29 16:12 [PATCH] oprofile: Thou shalt not call __exit functions from __init functions Russell King
2009-03-30 0:17 ` Rusty Russell
2009-03-31 11:49 ` Robert Richter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox