Re: [PATCH] ext4: fix blkdev_issue_flush() failure handling

Eric Sandeen
2009-03-30T03:22:30Z

Theodore Tso wrote:
> On Sun, Mar 29, 2009 at 12:43:22PM -0500, Eric Sandeen wrote:
>> As long as we keep the call there this is probably good, but after
>> talking w/ Chris Mason, I think the call is extraneous anyway and should
>> probably just be removed...
>>
>
> Yes, I agree, but it takes a lot of digging to be completely sure of
> that it's safe to remove it. Interestingly, it was you who added the
> patch which added the call to blkdev_issue_flush():

> commit d755fb384250d6bd7fd18a0930e71965acc8e72e
> Author: Eric Sandeen <sandeen@redhat.com>
> Date: Fri Jul 11 19:27:31 2008 -0400

Yes, it was. Although I got the idea when hch pointed out that SuSE did
this... thanks to Chris. It's come full circle. :)

-Eric