public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Gautham R Shenoy <ego@in.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: "Ingo Molnar" <mingo@elte.hu>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Gautham R Shenoy <ego@in.ibm.com>
Subject: [PATCH] sched: Print sched_group::__cpu_power in sched_domain_debug.
Date: Mon, 30 Mar 2009 10:25:20 +0530	[thread overview]
Message-ID: <20090330045520.2869.24777.stgit@sofia.in.ibm.com> (raw)
In-Reply-To: <20090330045321.2869.9284.stgit@sofia.in.ibm.com>

If the user changes the value of the sched_mc/smt_power_savings sysfs tunable,
it'll trigger a rebuilding of the whole sched_domain tree, with the
SD_POWERSAVINGS_BALANCE flag set at certain levels.

As a result, there would be a change in the __cpu_power of sched_groups
in the sched_domain hierarchy.

Print the __cpu_power values for each sched_group in sched_domain_debug
to help verify this change and correlate it with the change in the
load-balancing behavior.

Signed-off-by: Gautham R Shenoy <ego@in.ibm.com>
---

 kernel/sched.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index 706517c..fbac83b 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -7363,7 +7363,8 @@ static int sched_domain_debug_one(struct sched_domain *sd, int cpu, int level,
 		cpumask_or(groupmask, groupmask, sched_group_cpus(group));
 
 		cpulist_scnprintf(str, sizeof(str), sched_group_cpus(group));
-		printk(KERN_CONT " %s", str);
+		printk(KERN_CONT " %s (__cpu_power = %d)", str,
+						group->__cpu_power);
 
 		group = group->next;
 	} while (group != sd->groups);


  reply	other threads:[~2009-03-30  4:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-30  4:55 [PATCH] sched: Print sched_group::__cpu_power in sched_domain_debug Gautham R Shenoy
2009-03-30  4:55 ` Gautham R Shenoy [this message]
2009-04-01 16:03   ` [tip:sched/urgent] " Gautham R Shenoy
2009-04-13 18:53     ` Tony Luck
2009-04-14  0:09       ` Ingo Molnar
2009-04-14  3:39         ` Gautham R Shenoy
2009-04-14 12:03           ` [tip:sched/urgent] sched: Avoid printing sched_group::__cpu_power for default case tip-bot for Gautham R Shenoy
2009-04-14 16:29           ` [tip:sched/urgent] sched: Print sched_group::__cpu_power in sched_domain_debug Luck, Tony
2009-04-14 17:06             ` Gautham R Shenoy
2009-04-14 17:18               ` Luck, Tony
2009-04-14 18:40                 ` Ingo Molnar
2009-04-14 18:42           ` [tip:sched/urgent] sched: Avoid printing sched_group::__cpu_power for default case tip-bot for Gautham R Shenoy
2009-04-16 22:48           ` tip-bot for Gautham R Shenoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090330045520.2869.24777.stgit@sofia.in.ibm.com \
    --to=ego@in.ibm.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox