From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753987AbZC3LwN (ORCPT ); Mon, 30 Mar 2009 07:52:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751254AbZC3Lvw (ORCPT ); Mon, 30 Mar 2009 07:51:52 -0400 Received: from moutng.kundenserver.de ([212.227.126.188]:51335 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751005AbZC3Lvv (ORCPT ); Mon, 30 Mar 2009 07:51:51 -0400 Date: Mon, 30 Mar 2009 13:52:02 +0200 From: Thierry Reding To: Heiko Carstens Cc: "David S. Miller" , Martin Schwidefsky , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: [PATCH] ETHOC: fix build breakage on s390 Message-ID: <20090330115202.GA13719@avionic-design.de> References: <20090330113015.21576898@osiris.boeblingen.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090330113015.21576898@osiris.boeblingen.de.ibm.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-Provags-ID: V01U2FsdGVkX1+Jo2dmjbh5uwTsh6DXcZ2XFO4MLMIuHeoaGDg jJAzQ0jHNeBbH1z4g8PePbfn9tqrZwU1tRKTxghLgzjzAx/oPJ Onpx+0akQDmmtjddHyI9Q== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Heiko Carstens wrote: > From: Heiko Carstens > > Let driver depend on HAS_IOMEM to avoid build breakage on s390: > > CC drivers/net/ethoc.o > drivers/net/ethoc.c: In function 'ethoc_read': > drivers/net/ethoc.c:221: error: implicit declaration of function 'ioread32' > drivers/net/ethoc.c: In function 'ethoc_write': > drivers/net/ethoc.c:226: error: implicit declaration of function 'iowrite32' > drivers/net/ethoc.c: In function 'ethoc_rx': > drivers/net/ethoc.c:405: error: implicit declaration of function 'memcpy_fromio' > drivers/net/ethoc.c: In function 'ethoc_start_xmit': > drivers/net/ethoc.c:828: error: implicit declaration of function 'memcpy_toio' > > Cc: Thierry Reding > Signed-off-by: Heiko Carstens > --- > drivers/net/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6/drivers/net/Kconfig > =================================================================== > --- linux-2.6.orig/drivers/net/Kconfig > +++ linux-2.6/drivers/net/Kconfig > @@ -974,7 +974,7 @@ config ENC28J60_WRITEVERIFY > > config ETHOC > tristate "OpenCores 10/100 Mbps Ethernet MAC support" > - depends on NET_ETHERNET > + depends on NET_ETHERNET && HAS_IOMEM > select MII > select PHYLIB > help Acked-by: Thierry Reding