From: Sam Ravnborg <sam@ravnborg.org>
To: Philipp Reisner <philipp.reisner@linbit.com>
Cc: linux-kernel@vger.kernel.org, gregkh@suse.de,
jens.axboe@oracle.com, nab@risingtidestorage.com,
andi@firstfloor.org, Lars Ellenberg <lars.ellenberg@linbit.com>
Subject: Re: [PATCH 13/13] DRBD: final
Date: Mon, 30 Mar 2009 21:05:30 +0200 [thread overview]
Message-ID: <20090330190530.GA4028@uranus.ravnborg.org> (raw)
In-Reply-To: <1238431643-19433-16-git-send-email-philipp.reisner@linbit.com>
> +#
> +config BLK_DEV_DRBD
> + tristate "DRBD Distributed Replicated Block Device support"
> + select INET
> + select PROC_FS
> + select CONNECTOR
> + select CRYPTO
> + select CRYPTO_HMAC
Have you double checked that these symbols are supposed to be 'selected'?
If they:
- have dependencies
- have a prompt
then they most likely are not.
> @@ -0,0 +1,7 @@
> +#CFLAGS_drbd_sizeof_sanity_check.o = -Wpadded # -Werror
Commented out?
> +
> +drbd-objs := drbd_buildtag.o drbd_bitmap.o drbd_proc.o \
> + drbd_worker.o drbd_receiver.o drbd_req.o drbd_actlog.o \
> + lru_cache.o drbd_main.o drbd_strings.o drbd_nl.o
Please use:
drdb-y := drbd_buildtag.o drbd_bitmap.o drbd_proc.o
...
And my personal taste favours:
drdb-y := ...
drdb-y += ...
over all the escaping.
Sam
next prev parent reply other threads:[~2009-03-30 19:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-30 16:47 [PATCH 00/12] DRBD: a block device for HA clusters Philipp Reisner
2009-03-30 16:47 ` [PATCH 01/13] DRBD: lru_cache Philipp Reisner
2009-03-30 16:47 ` [PATCH 02/13] DRBD: activity_log Philipp Reisner
2009-03-30 16:47 ` [PATCH 03/13] DRBD: bitmap Philipp Reisner
2009-03-30 16:47 ` [PATCH 04/13] DRBD: request Philipp Reisner
2009-03-30 16:47 ` [PATCH 05/13] DRBD: userspace_interface Philipp Reisner
2009-03-30 16:47 ` [PATCH 06/13] DRBD: internal_data_structures Philipp Reisner
2009-03-30 16:47 ` [PATCH 07/13] DRBD: main Philipp Reisner
2009-03-30 16:47 ` [PATCH 08/13] DRBD: receiver Philipp Reisner
2009-03-30 16:47 ` [PATCH 09/13] DRBD: proc Philipp Reisner
2009-03-30 16:47 ` [PATCH 10/13] DRBD: worker Philipp Reisner
2009-03-30 16:47 ` [PATCH 11/12] DRBD: misc Philipp Reisner
2009-03-30 16:47 ` [PATCH 11/13] DRBD: variable_length_integer_encoding Philipp Reisner
2009-03-30 16:47 ` [PATCH 12/12] DRBD: final Philipp Reisner
2009-03-30 16:47 ` [PATCH 12/13] DRBD: misc Philipp Reisner
2009-03-30 16:47 ` [PATCH 13/13] DRBD: final Philipp Reisner
2009-03-30 19:05 ` Sam Ravnborg [this message]
2009-04-01 10:13 ` Philipp Reisner
2009-04-07 10:26 ` [PATCH 00/12] DRBD: a block device for HA clusters Lars Marowsky-Bree
2009-04-07 12:23 ` Nikanth K
2009-04-07 15:56 ` Philipp Reisner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090330190530.GA4028@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=andi@firstfloor.org \
--cc=gregkh@suse.de \
--cc=jens.axboe@oracle.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nab@risingtidestorage.com \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox