From: David Miller <davem@davemloft.net>
To: tj@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Inverted NUMA test in setup_pcpu_remap()?
Date: Tue, 31 Mar 2009 22:31:28 -0700 (PDT) [thread overview]
Message-ID: <20090331.223128.143365884.davem@davemloft.net> (raw)
The test currently is:
if (!cpu_has_pse || pcpu_need_numa())
return -EINVAL;
Don't we really mean "!pcpu_need_numa()"?
The way I read the intent, setup_pcpu_remap() should be used in the
NUMA case. But that's not what's happening because of how this test
is coded.
In fact, the test here is identical to the one used in
setup_pcpu_embed()
next reply other threads:[~2009-04-01 5:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-01 5:31 David Miller [this message]
2009-04-01 5:56 ` Inverted NUMA test in setup_pcpu_remap()? Yinghai Lu
2009-04-01 6:06 ` [PATCH] x86,percpu: fix inverted NUMA test in setup_pcpu_remap() Tejun Heo
2009-04-01 7:27 ` [PATCH] x86: remove duplicated code with pcpu_need_numa() Yinghai Lu
2009-04-01 7:33 ` Tejun Heo
2009-04-01 8:04 ` David Miller
2009-04-02 4:09 ` [tip:x86/urgent] " Yinghai Lu
2009-04-02 4:09 ` [tip:x86/urgent] x86,percpu: fix inverted NUMA test in setup_pcpu_remap() Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090331.223128.143365884.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox