Re: [patch 0/4] Intel IOMMU Supspend/Resume Support

[fenghua.yu@intel.com]

>>
>> The attached patch set implements the suspend and resume feature for
>Intel
>> IOMMU. It hooks to kernel suspend and resume interface. When suspend
>happens, itsaves necessary hardware registers. When resume happens, it
>restores the
>> registers and restarts IOMMU.
>>
>> This patch set can be applied on the tip tree.
>
>Looks good to me, apart from the fact that your #4 patch actually needs
>to come before #1. Shall I apply it to my iommu-2.6.git tree or let Ingo
>take it? If the latter,
>
>Acked-by: David Woodhouse <David.Woodhouse@intel.com>
>Acked-by: David Woodhouse <David.Woodhouse@intel.com>
>Acked-by: David Woodhouse <David.Woodhouse@intel.com>
>Acked-by: David Woodhouse <David.Woodhouse@intel.com>
>
>(if you look carefully, you'll see those are in order 4, 1, 2, 3)
>
>Have we tested this on IA64?

Since ia64 platforms don't support suspend/resume, the code won't take action onia64. But it still installs unused sys device interface.

I'll clean up the code for ia64 and re-send the patch set.

Thanks.

-Fenghua

--