From: Al Viro <viro@ZenIV.linux.org.uk>
To: Manish Katiyar <mkatiyar@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
trivial@kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] : Code cleanup for fs/inode.c as per checkpatch.pl
Date: Tue, 31 Mar 2009 10:16:53 +0100 [thread overview]
Message-ID: <20090331091653.GU28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <ea11fea30903310202i738c1f05y754ea0a1a56574eb@mail.gmail.com>
On Tue, Mar 31, 2009 at 02:32:37PM +0530, Manish Katiyar wrote:
> -static struct inode * find_inode(struct super_block * sb, struct hlist_head *head, int (*test)(struct inode *, void *), void *data)
> +static struct inode *find_inode(struct super_block *sb, struct hlist_head *head,
> + int (*test)(struct inode *, void *), void *data)
If you are splitting it, split it all the way, esp. the last line.
> -static struct inode * get_new_inode(struct super_block *sb, struct hlist_head *head, int (*test)(struct inode *, void *), int (*set)(struct inode *, void *), void *data)
> +static struct inode *get_new_inode(struct super_block *sb,
> + struct hlist_head *head,
> + int (*test)(struct inode *, void *),
> + int (*set)(struct inode *, void *), void *data)
Ditto, and that's even more serious case - here 'void *data' part is
really obfuscated.
next prev parent reply other threads:[~2009-03-31 9:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ea11fea30903222039r4bec470crfd9825e37a926d56@mail.gmail.com>
[not found] ` <20090330163619.d08ba85e.akpm@linux-foundation.org>
2009-03-31 2:43 ` [PATCH] : Code cleanup for fs/inode.c as per checkpatch.pl Manish Katiyar
2009-03-31 6:04 ` Al Viro
2009-03-31 9:02 ` Manish Katiyar
2009-03-31 9:16 ` Al Viro [this message]
2009-03-31 14:05 ` Manish Katiyar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090331091653.GU28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkatiyar@gmail.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox