Re: [PATCH 4/4] add ksm kernel shared memory driver.

Chris Wright
2009-04-02T01:22:44Z

* Anthony Liguori (anthony@codemonkey.ws) wrote:
> The ioctl() interface is quite bad for what you're doing. You're
> telling the kernel extra information about a VA range in userspace.
> That's what madvise is for. You're tweaking simple read/write values of
> kernel infrastructure. That's what sysfs is for.

I agree re: sysfs (brought it up myself before). As far as madvise vs.
ioctl, the one thing that comes from the ioctl is fops->release to
automagically unregister memory on exit. This needs to be handled
anyway if some -p pid is added to add a process after it's running,
so less weight there.

thanks,
-chris