public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Azael Avalos <coproscefalo@gmail.com>
Cc: linux-acpi@vger.kernel.org, dsilvers@simtec.co.uk,
	toshiba_acpi@memebeam.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] toshiba-acpi: Support TOS1900-type devices
Date: Wed, 1 Apr 2009 00:02:17 +0100	[thread overview]
Message-ID: <20090331230217.GA31599@srcf.ucam.org> (raw)
In-Reply-To: <74962ea30903311519s2fb6087fxfe8859e3c570ac99@mail.gmail.com>

Ok, can you try this and let me know what codes it generates (if it 
generates any)? It should go on top of the previous patches.

diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c
index 9fb4873..8552e1a 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b/drivers/platform/x86/toshiba_acpi.c
@@ -185,7 +185,6 @@ static int write_acpi_int(const char *methodName, int val)
 	return (status == AE_OK);
 }
 
-#if 0
 static int read_acpi_int(const char *methodName, int *pVal)
 {
 	struct acpi_buffer results;
@@ -200,7 +199,6 @@ static int read_acpi_int(const char *methodName, int *pVal)
 
 	return (status == AE_OK) && (out_objs[0].type == ACPI_TYPE_INTEGER);
 }
-#endif
 
 static const char *method_hci /*= 0*/ ;
 
@@ -802,6 +800,13 @@ static void toshiba_acpi_notify(acpi_handle handle, u32 event, void **data)
 
 	if (event != 0x80)
 		return;
+
+	if (is_valid_acpi_path(TOSH_INTERFACE_2 SPFC_METHOD)) {
+		read_acpi_int(TOSH_INTERFACE_2 SPFC_METHOD, &value);
+		printk("Received 0x%x\n", value);
+		return;
+	}
+
 	do {
 		hci_read1(HCI_SYSTEM_EVENT, &value, &hci_result);
 		if (hci_result == HCI_SUCCESS) {

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2009-03-31 23:02 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-31 21:45 [PATCH 1/2] toshiba-acpi: Add support for hotkey notifications Matthew Garrett
2009-03-31 21:47 ` [PATCH 2/2] toshiba-acpi: Support TOS1900-type devices Matthew Garrett
2009-03-31 22:06   ` Azael Avalos
2009-03-31 22:11     ` Matthew Garrett
2009-03-31 22:19       ` Azael Avalos
2009-03-31 23:02         ` Matthew Garrett [this message]
2009-04-01 16:50           ` Azael Avalos
2009-04-01 16:53             ` Matthew Garrett
2009-04-01 17:03               ` Azael Avalos
2009-04-01 17:07                 ` Matthew Garrett
2009-04-01 17:13                   ` Azael Avalos
2009-06-02 14:03                     ` Matthew Garrett
2009-06-09 16:42                       ` Azael Avalos
2009-06-09 16:45                         ` Matthew Garrett
2009-06-10  0:18                           ` Azael Avalos
2009-06-10  0:22                             ` Matthew Garrett
2009-06-10  0:29                               ` Azael Avalos
2009-06-18  0:35                                 ` Azael Avalos
2009-04-08  5:44 ` [PATCH 1/2] toshiba-acpi: Add support for hotkey notifications Len Brown
2009-04-11 19:50 ` Frans Pop
2009-04-13 14:50   ` Matthew Garrett
2009-04-13 19:28     ` Frans Pop
2009-04-13 19:43       ` Matthew Garrett
2009-04-13 20:38         ` Frans Pop
2009-04-13 21:18           ` Matthew Garrett
2009-04-13 21:26             ` Frans Pop
2009-04-13 21:31               ` Matthew Garrett
2009-04-18  4:01 ` Len Brown
2009-04-18  5:47   ` Andrey Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090331230217.GA31599@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=coproscefalo@gmail.com \
    --cc=dsilvers@simtec.co.uk \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=toshiba_acpi@memebeam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox