From: Ingo Molnar <mingo@elte.hu>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: Oleg Nesterov <oleg@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"hpa@zytor.com" <hpa@zytor.com>,
"markus.t.metzger@gmail.com" <markus.t.metzger@gmail.com>,
"roland@redhat.com" <roland@redhat.com>,
"eranian@googlemail.com" <eranian@googlemail.com>,
"Villacis, Juan" <juan.villacis@intel.com>,
"ak@linux.jf.intel.com" <ak@linux.jf.intel.com>
Subject: Re: [patch 0/21] x86, ptrace, bts, hw-branch-tracer: fixes and cleanups
Date: Wed, 1 Apr 2009 13:45:57 +0200 [thread overview]
Message-ID: <20090401114557.GC23678@elte.hu> (raw)
In-Reply-To: <928CFBE8E7CB0040959E56B4EA41A77E926D4FDE@irsmsx504.ger.corp.intel.com>
* Metzger, Markus T <markus.t.metzger@intel.com> wrote:
> >-----Original Message-----
> >From: Oleg Nesterov [mailto:oleg@redhat.com]
> >Sent: Wednesday, April 01, 2009 1:40 AM
> >To: Metzger, Markus T
>
>
> >> The first 5 patches apply to .29 with the small preparation patch below.
> >
> >Tried to review these patches.
> >
> >As I said, I don't understand ds.c, but I _think_ these changes are good.
> >
> >I only have a couple of really minor nitpicks...
>
> Thanks for your review!
> I will address the nitpicks in separate patches, if that's OK with everyone.
Please dont forget to propagate Oleg's Reviewed-by (or Acked-by)
tags into the commits.
> Regarding bisecting, I split the patches to attract reviewers to
> the smaller parts rather than scare them off with one big patch.
>
> I hope that the bisecting tool can cope with broken builds between
> patches.
It cannot, and even if it did we dont want a single intentionally
broken bisection point in the kernel. Please do small patches that
build fine at each step. We've got more than 100,000 bisectable
commits in the kernel to look at. If you think it's not possible in
a specific case then please describe the situation to us so that we
can suggest a solution.
Ingo
next prev parent reply other threads:[~2009-04-01 11:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-31 12:42 [patch 0/21] x86, ptrace, bts, hw-branch-tracer: fixes and cleanups Markus Metzger
2009-03-31 23:39 ` Oleg Nesterov
2009-04-01 7:05 ` Metzger, Markus T
2009-04-01 11:45 ` Ingo Molnar [this message]
2009-04-01 12:56 ` Metzger, Markus T
2009-04-01 13:18 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090401114557.GC23678@elte.hu \
--to=mingo@elte.hu \
--cc=ak@linux.jf.intel.com \
--cc=eranian@googlemail.com \
--cc=hpa@zytor.com \
--cc=juan.villacis@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.t.metzger@gmail.com \
--cc=markus.t.metzger@intel.com \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox