From: Ingo Molnar <mingo@elte.hu>
To: Tom Zanussi <tzanussi@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
fweisbec@gmail.com
Subject: Re: [PATCH] tracing/filters: allow event filters to be set only when not tracing
Date: Wed, 1 Apr 2009 14:24:08 +0200 [thread overview]
Message-ID: <20090401122408.GG12966@elte.hu> (raw)
In-Reply-To: <1238390546.6368.65.camel@bookworm>
* Tom Zanussi <tzanussi@gmail.com> wrote:
> This patch adds code allowing the event filter to be set only if
> there's no active tracing going on.
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -498,6 +498,9 @@ event_filter_write(struct file *filp, const char __user *ubuf, size_t cnt,
> struct filter_pred *pred;
> int err;
>
> + if (tracing_is_enabled() && (!tracer_is_nop() || call->enabled))
> + return -EBUSY;
hm, but it would be the normal use-case to set filters on the fly.
To experiment around with them and shape them until the output is
just right. Having to turn the tracer on/off during that seems quite
counterproductive to that use-case.
Ingo
next prev parent reply other threads:[~2009-04-01 12:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-30 5:22 [PATCH] tracing/filters: allow event filters to be set only when not tracing Tom Zanussi
2009-04-01 12:24 ` Ingo Molnar [this message]
2009-04-02 6:22 ` Tom Zanussi
2009-04-03 13:59 ` Ingo Molnar
2009-04-03 14:12 ` Steven Rostedt
2009-04-04 7:32 ` Tom Zanussi
2009-04-04 15:49 ` Steven Rostedt
2009-04-04 17:02 ` Paul E. McKenney
2009-04-05 7:34 ` Tom Zanussi
2009-04-05 17:11 ` Paul E. McKenney
2009-04-06 15:59 ` Steven Rostedt
2009-04-06 16:15 ` Paul E. McKenney
2009-04-06 19:30 ` Steven Rostedt
2009-04-06 19:44 ` Frederic Weisbecker
2009-04-06 19:52 ` Steven Rostedt
2009-04-06 20:15 ` Paul E. McKenney
2009-04-06 23:58 ` Paul E. McKenney
2009-04-07 0:34 ` Steven Rostedt
2009-04-07 1:27 ` Paul E. McKenney
2009-04-03 16:26 ` Paul E. McKenney
2009-04-03 16:37 ` Ingo Molnar
2009-04-03 16:43 ` Steven Rostedt
2009-04-03 18:05 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090401122408.GG12966@elte.hu \
--to=mingo@elte.hu \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox