public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Tom Zanussi <tzanussi@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] tracing/filters: add run-time field descriptions to TRACE_EVENT_FORMAT events
Date: Wed, 1 Apr 2009 14:25:16 +0200	[thread overview]
Message-ID: <20090401122516.GH12966@elte.hu> (raw)
In-Reply-To: <1238474638.10508.51.camel@bookworm>


* Tom Zanussi <tzanussi@gmail.com> wrote:

> > Oh, do you know why these unfiltered event are disappearing?
> 
> It's because of the way ring_buffer_discard() currently works - 
> the filtered events are still there in the ring buffer taking up 
> space; they just aren't visible in the output because the read 
> skips over them.
> 
> So if there's a high volume of events being recorded, any given 
> event can be quickly overwritten before it has a chance to be 
> read, or it may have been read and appeared in the output, but 
> between the time it was read and the next cat, could easily have 
> been overwritten, and therefore 'disappears' on the next cat.
> 
> It's really no different from the normal case where there is no 
> filtering in place - the same thing would happen but you wouldn't 
> notice whether a particular event was still there or not the next 
> time you cat'ed the file, because of the large volume of events 
> being displayed. It's just more apparent when most of the events 
> are discarded and invisible.
> 
> At least that's my theory based on my understanding of how the 
> ring-buffer works...

Correct, and this needs to be fixed.

	Ingo

  reply	other threads:[~2009-04-01 12:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-30  5:22 [PATCH] tracing/filters: add run-time field descriptions to TRACE_EVENT_FORMAT events Tom Zanussi
2009-03-30 10:38 ` Frederic Weisbecker
2009-03-31  4:43   ` Tom Zanussi
2009-04-01 12:25     ` Ingo Molnar [this message]
2009-04-02  1:36       ` Steven Rostedt
2009-04-02  1:58         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090401122516.GH12966@elte.hu \
    --to=mingo@elte.hu \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox