From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>, Jens Axboe <jens.axboe@oracle.com>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] blktrace: fix output of unknown events
Date: Wed, 1 Apr 2009 09:46:23 -0300 [thread overview]
Message-ID: <20090401124623.GC25493@ghostprotocols.net> (raw)
In-Reply-To: <49D3236D.3090705@cn.fujitsu.com>
Em Wed, Apr 01, 2009 at 04:18:53PM +0800, Li Zefan escreveu:
> Not all events are pc (packet command) events. An event is a pc
> event only if it has BLK_TC_PC bit set.
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> ---
> kernel/trace/blktrace.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
> index 947c5b3..464a6e5 100644
> --- a/kernel/trace/blktrace.c
> +++ b/kernel/trace/blktrace.c
> @@ -1181,7 +1181,7 @@ static enum print_line_t print_one_line(struct trace_iterator *iter,
> }
>
> if (unlikely(what == 0 || what >= ARRAY_SIZE(what2act)))
> - ret = trace_seq_printf(s, "Bad pc action %x\n", what);
> + ret = trace_seq_printf(s, "Unknown action %x\n", what);
> else {
> ret = log_action(iter, what2act[what].act[long_act]);
> if (ret)
Looks ok,
Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
next prev parent reply other threads:[~2009-04-01 12:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-01 8:18 [PATCH 1/2] blktrace: fix output of unknown events Li Zefan
2009-04-01 8:19 ` [PATCH 2/2] blktrace: fix output of BLK_TC_PC events Li Zefan
2009-04-01 11:00 ` Ingo Molnar
2009-04-01 12:52 ` Arnaldo Carvalho de Melo
2009-04-11 8:15 ` Li Zefan
2009-04-12 13:07 ` Ingo Molnar
2009-04-12 13:10 ` Jens Axboe
2009-04-12 13:37 ` Ingo Molnar
2009-04-13 0:43 ` Li Zefan
2009-04-13 0:40 ` Li Zefan
2009-04-13 22:22 ` [tip:tracing/core] " tip-bot for Li Zefan
2009-04-01 12:46 ` Arnaldo Carvalho de Melo [this message]
2009-04-13 22:22 ` [tip:tracing/core] blktrace: fix output of unknown events tip-bot for Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090401124623.GC25493@ghostprotocols.net \
--to=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox