From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: user-mode-linux-devel@lists.sourceforge.net, jdike@addtoit.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 1/3] uml: fix compile error from net_device_ops conversion
Date: Wed, 1 Apr 2009 23:49:24 +0800 [thread overview]
Message-ID: <20090401154924.GD3848@hack> (raw)
In-Reply-To: <E1LoMQ2-0007bB-By@pomaz-ex.szeredi.hu>
On Mon, Mar 30, 2009 at 08:41:10PM +0200, Miklos Szeredi wrote:
>From: Miklos Szeredi <mszeredi@suse.cz>
>
>Fix the following compile error:
>
>arch/um/drivers/net_kern.c: In function 'uml_inetaddr_event':
>arch/um/drivers/net_kern.c:760: error: 'struct net_device' has no member named 'open'
>
>This was introduced by commit 8bb95b39, "uml: convert network device
>to netdevice ops".
>
>Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>
Thanks.
>---
> arch/um/drivers/net_kern.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>Index: linux-2.6/arch/um/drivers/net_kern.c
>===================================================================
>--- linux-2.6.orig/arch/um/drivers/net_kern.c 2009-03-30 17:07:10.000000000 +0200
>+++ linux-2.6/arch/um/drivers/net_kern.c 2009-03-30 19:25:30.000000000 +0200
>@@ -757,7 +757,7 @@ static int uml_inetaddr_event(struct not
> void (*proc)(unsigned char *, unsigned char *, void *);
> unsigned char addr_buf[4], netmask_buf[4];
>
>- if (dev->open != uml_net_open)
>+ if (dev->netdev_ops->ndo_open != uml_net_open)
> return NOTIFY_DONE;
>
> lp = netdev_priv(dev);
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
--
Do what you love, f**k the rest! F**k the regulations!
prev parent reply other threads:[~2009-04-01 15:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-30 18:41 [patch 1/3] uml: fix compile error from net_device_ops conversion Miklos Szeredi
2009-03-30 18:42 ` Miklos Szeredi
2009-03-30 18:45 ` [patch 3/3] uml: fix warnings in kernel_execve Miklos Szeredi
2009-04-01 16:11 ` do_execve() needs const qualifiers (was Re: [patch 3/3] uml: fix warnings in kernel_execve) Américo Wang
2009-04-01 16:21 ` Al Viro
2009-04-04 16:51 ` Américo Wang
2009-03-30 18:47 ` [patch 2/3] uml: fix link error from prefixing of i386 syscalls with ptregs_ Miklos Szeredi
2009-04-01 16:03 ` Américo Wang
2009-04-01 15:49 ` Américo Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090401154924.GD3848@hack \
--to=xiyou.wangcong@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox