public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jean Delvare <khali@linux-fr.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Howells <dhowells@redhat.com>,
	Oleg Nesterov <oleg@tv-sign.ru>,
	Marcin Slusarz <marcin.slusarz@gmail.com>
Subject: Re: [PATCH] Add to_delayed_work helper function
Date: Thu, 2 Apr 2009 13:22:29 +0200	[thread overview]
Message-ID: <20090402112229.GC10828@elte.hu> (raw)
In-Reply-To: <20090402131137.0b268f9a@hyperion.delvare>


* Jean Delvare <khali@linux-fr.org> wrote:

> It is a fairly common operation to have a pointer to a work and to
> need a pointer to the delayed work it is contained in. In particular,
> all delayed works which want to rearm themselves will have to do that.
> So it would seem fair to offer a helper function for this operation.
> 
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Acked-by: Ingo Molnar <mingo@elte.hu>
> ---
> Patch updated to include new users. It would be nice to have this patch
> merged soon so that I no longer have to update it. Andrew?

Andrew, iff it's comprehensively build-tested then this should go 
into .30 from -mm, right?

Because this:

>  arch/powerpc/kernel/vio.c                               |    2 +-
>  drivers/crypto/hifn_795x.c                              |    2 +-
>  drivers/input/mouse/hgpk.c                              |    2 +-
>  drivers/net/dm9000.c                                    |    2 +-
>  drivers/net/mlx4/en_netdev.c                            |    2 +-
>  drivers/net/mlx4/en_rx.c                                |    2 +-
>  drivers/net/mlx4/sense.c                                |    2 +-
>  drivers/net/phy/phy.c                                   |    3 +--
>  drivers/s390/scsi/zfcp_fc.c                             |    2 +-
>  drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c |    8 ++++----
>  drivers/staging/rtl8187se/r8180_core.c                  |    8 ++++----
>  drivers/staging/rtl8187se/r8180_dm.c                    |    6 +++---
>  drivers/usb/wusbcore/devconnect.c                       |    2 +-
>  include/linux/workqueue.h                               |    5 +++++
>  mm/slab.c                                               |    3 +--
>  15 files changed, 27 insertions(+), 24 deletions(-)

... will be painful to port across another cycle.

( and it's pointless to delay as well, this is an obvious cleanup 
  well in line with how we use to_*() container constructs elsewhere 
  in the driver frameworks. )

	Ingo

  reply	other threads:[~2009-04-02 11:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-02 11:11 [PATCH] Add to_delayed_work helper function Jean Delvare
2009-04-02 11:22 ` Ingo Molnar [this message]
2009-04-02 16:17   ` Andrew Morton
  -- strict thread matches above, loose matches on Subject: below --
2009-03-03 13:38 Jean Delvare
2009-03-03  7:34 [PATCH] Add to_delayed_work macro Jean Delvare
2009-03-03  8:29 ` Andrew Morton
2009-03-03 12:06   ` [PATCH] Add to_delayed_work helper function Jean Delvare
2009-03-03 12:11     ` Ingo Molnar
2009-03-03 13:28       ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090402112229.GC10828@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcin.slusarz@gmail.com \
    --cc=oleg@tv-sign.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox