From: Theodore Tso <tytso@mit.edu>
To: Thiemo Nagel <thiemo.nagel@ph.tum.de>
Cc: Alexander Beregalov <a.beregalov@gmail.com>,
Jens Axboe <jens.axboe@oracle.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: 2.6.29-git: cannot mount ext4/loop
Date: Thu, 2 Apr 2009 10:54:36 -0400 [thread overview]
Message-ID: <20090402145436.GF10642@mit.edu> (raw)
In-Reply-To: <49D4BDF2.2070102@ph.tum.de>
On Thu, Apr 02, 2009 at 03:30:26PM +0200, Thiemo Nagel wrote:
> When I added the block range checks, initially I was assuming that
> when EXTENTS_FL is not set, the inode->i_data *always* contains
> references to further blocks. Ted showed me wrong and added the condition
>
> ISREG() || ISDIR() || ( ISLNK() && !is_fast_symlink() )
>
> before that assumption can be made. But maybe we need some further
> restraints?
It's a endian-problem; we're missing le32_to_cpu() in that patch.
Sparc is big-endian.
Alexander, thanks for pointing this out. We'll have to get this fixed
and pushed to Linus ASAP.
- Ted
next prev parent reply other threads:[~2009-04-02 14:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-01 21:23 2.6.29-git: cannot mount ext4/loop Alexander Beregalov
2009-04-01 22:53 ` Alexander Beregalov
2009-04-02 5:53 ` Theodore Tso
2009-04-02 7:42 ` Alexander Beregalov
2009-04-02 11:39 ` Alexander Beregalov
2009-04-02 12:47 ` Alexander Beregalov
2009-04-02 13:30 ` Thiemo Nagel
2009-04-02 14:54 ` Theodore Tso [this message]
2009-04-02 15:18 ` Thiemo Nagel
2009-04-02 15:41 ` Theodore Tso
2009-04-02 17:05 ` Thiemo Nagel
2009-04-02 18:29 ` Alexander Beregalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090402145436.GF10642@mit.edu \
--to=tytso@mit.edu \
--cc=a.beregalov@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thiemo.nagel@ph.tum.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox