RE: [patch 14/18] x86, ds: use single debug store cpu configuration

Metzger, Markus T
2009-04-03T06:46:46Z

>-----Original Message-----
>From: Ingo Molnar [mailto:mingo@elte.hu]
>Sent: Thursday, April 02, 2009 9:30 PM
>To: Metzger, Markus T
>Cc: tglx@linutronix.de; hpa@zytor.com; markus.t.metzger@gmail.com; roland@redhat.com;
>eranian@googlemail.com; oleg@redhat.com; Villacis, Juan; ak@linux.jf.intel.com; linux-
>kernel@vger.kernel.org
>Subject: Re: [patch 14/18] x86, ds: use single debug store cpu configuration
>
>
>* markus.t.metzger@intel.com <markus.t.metzger@intel.com> wrote:
>
>> Use a single configuration for all cpus.
>>
>
>> @@ -1291,11 +1290,15 @@ ds_configure(const struct ds_configurati
>> printk("bts/pebs record: %u/%u bytes\n",
>> ds_cfg.sizeof_rec[ds_bts], ds_cfg.sizeof_rec[ds_pebs]);
>>
>> - WARN_ON_ONCE(MAX_SIZEOF_DS < (12 * ds_cfg.sizeof_ptr_field));
>> + WARN_ON(MAX_SIZEOF_DS < (12 * ds_cfg.sizeof_ptr_field));
>
>Why this change?

The function is only called once, now - for the boot cpu.
The _ONCE is a nop. I thought its better to remove it, since it became redundant.

regards,
markus.

>
>Firstly, it was not declared in the changelog which is a no-no.
>
>Secondly, this is a bad change: we are more than content to have a
>single such warning bootup - not dozens of it (on some large
>system).
>
> Ingo