Re: [patch 13/18] x86, ds: add leakage warning

Ingo Molnar
2009-04-02T19:28:22Z

* markus.t.metzger@intel.com <markus.t.metzger@intel.com> wrote:

> +static inline void ds_warn_leak(struct task_struct *tsk)
> +{
> + WARN(tsk->thread.ds_ctx, "leaking DS context\n");
> +}

> + ds_warn_leak(tsk);

since we normally expect X86_DS enabled i'd suggest this
simplification: always have thread.ds_ctx around so the WARN_ON can
go there unconditionally. (it wont trigger in the !DS case)

> struct task_struct;
> struct mm_struct;
> +struct ds_context;

why is this needed in processor.h?

ds.h should be split into ds_types.h and ds_api.h, with the pure
data type definitions in ds_types.h. processor.h (which needs to
know about the DS context type) then includes ds_types.h - which
is a lightweight header.

Actual DS using facilities also disable ds_api.h.

This keeps data types nicely separated from methods and inlines.

Ingo