public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Clark Williams <williams@redhat.com>
To: "Frédéric Weisbecker" <fweisbec@gmail.com>
Cc: Jon Masters <jcm@jonmasters.org>,
	LKML <linux-kernel@vger.kernel.org>, Jon Masters <jcm@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Steven Rostedt <rostedt@goodmis.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Luis Claudio R. Goncalves" <lgoncalv@redhat.com>
Subject: Re: [PATCH 1/2] SMI Detector: a simple module for detecting System Management Interrupts
Date: Thu, 2 Apr 2009 15:16:21 -0500	[thread overview]
Message-ID: <20090402151621.171a95c9@torg> (raw)
In-Reply-To: <c62985530904021205t2030c81o3d6439ab6a3a5e1e@mail.gmail.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thu, 2 Apr 2009 21:05:26 +0200
Frédéric Weisbecker <fweisbec@gmail.com> wrote:


> > +#if 1
> > +       val = simple_strtol(buffer, NULL, 10);
> > +#else
> > +       if (strict_strtol(buffer, 10, &val))
> > +               return -EINVAL;
> > +#endif
> 
> 
> 
> So I guess the #else statement can disappear? :-)
> 
> 

Ugh, don't blame Jon for that. I was trying to get rid of some
checkpatch warnings and was experimenting with strict vs. simple
strtol. 

I'll clean that up in the next iteration. Or Jon can and will then
abuse me :)

Clark

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)

iEYEARECAAYFAknVHRoACgkQHyuj/+TTEp0ndwCfe4ZeEsdflVY3udv9ukk7wKVQ
OycAn1Nl1OQr7nPUxPp3rln5SYVE4Bcn
=kZRN
-----END PGP SIGNATURE-----
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

  reply	other threads:[~2009-04-02 20:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-02 16:50 [PATCH 0/2] smi_detector: a simple module for detecting System Management Interrupts Jon Masters
2009-04-02 16:50 ` [PATCH 1/2] SMI Detector: " Jon Masters
2009-04-02 19:05   ` Frédéric Weisbecker
2009-04-02 20:16     ` Clark Williams [this message]
2009-04-04 15:28       ` Jon Masters
2009-04-09 20:12   ` Andrew Morton
2009-04-02 16:50 ` [PATCH 2/2] SMI detector: add license to the user smidetect script Jon Masters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090402151621.171a95c9@torg \
    --to=williams@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=jcm@jonmasters.org \
    --cc=jcm@redhat.com \
    --cc=lgoncalv@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox