Re: [PATCH 4/4] add ksm kernel shared memory driver.

Anthony Liguori
2009-04-02T00:32:01Z

Izik Eidus wrote:
> Anthony, the biggest problem about madvice() is that it is a real
> system call api, i wouldnt want in that stage of ksm commit into api
> changes of linux...
>
> The ioctl itself is restricting, madvice is much more...,
>
> Can we draft this issue to after ksm is merged, and after all the big
> new fetures that we want to add to ksm will be merge....
> (then the api would be much more stable, and we will be able to ask
> ppl in the list about changing of api, but for new driver that it yet
> to be merged, it is kind of overkill to add api to linux)
>
> What do you think?

You can't change ABIs after something is merged or you break userspace.
So you need to figure out the right ABI first.

Regards,

Anthony Liguori