Re: [PATCH 5/4] update ksm userspace interfaces

Chris Wright
2009-04-03T16:22:53Z

* Gerd Hoffmann (kraxel@redhat.com) wrote:
> mmput() call was in ->release() callback, ->release() in turn never was
> called because the kernel didn't zap the mappings because of the
> reference ...

Don't have this issue. That mmput() is not tied to zapping mappings,
rather zapping files. IOW, I think you're saying exit_mmap() wasn't
running due to your get_task_mm() (quite understandable, you still hold
a ref), whereas this ref is tied to exit_files().

So do_exit would do:

exit_mm
mmput <-- not dropped yet
exit_files
->release
mmput <-- dropped here

thanks,
-chris