From: Sam Ravnborg <sam@ravnborg.org>
To: Len Brown <lenb@kernel.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Stephen Rothwell <sfr@canb.auug.org.au>,
yakui_zhao <yakui.zhao@intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] acpi: simplify module_param namespace
Date: Thu, 2 Apr 2009 23:26:25 +0200 [thread overview]
Message-ID: <20090402212625.GA8502@uranus.ravnborg.org> (raw)
In-Reply-To: <alpine.LFD.2.00.0904021659190.4660@localhost.localdomain>
> +
> +processor-objs += processor_core.o processor_throttling.o \
> + processor_idle.o processor_thermal.o
> +ifdef CONFIG_CPU_FREQ
> +processor-objs += processor_perflib.o
> +endif
It would be nicer to do:
processor-y := processor_core.o processor_throttling.o
processor-y += processor_idle.o processor_thermal.o
processor-$(CONFIG_CPU_FREQ) += processor_perflib.o
Assuming processor-objs was not assinged before in this file.
Sam
next prev parent reply other threads:[~2009-04-02 21:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-07 2:58 [PATCH] acpi: simplify module_param namespace Rusty Russell
2009-03-09 2:20 ` yakui_zhao
2009-03-10 22:57 ` Rusty Russell
2009-03-11 3:51 ` Stephen Rothwell
2009-03-11 22:37 ` Rusty Russell
2009-04-02 21:03 ` Len Brown
2009-04-02 21:26 ` Sam Ravnborg [this message]
2009-04-03 2:44 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090402212625.GA8502@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=sfr@canb.auug.org.au \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox