From: Jack Steiner <steiner@sgi.com>
To: akpm@linux-foundation.org, mingo@elte.hu, rusty@rustcorp.com.au,
sfr@canb.auug.org.au
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] - Fix slab corruption caused by alloc_cpumask_var_node()
Date: Thu, 2 Apr 2009 16:27:51 -0500 [thread overview]
Message-ID: <20090402212751.GA11495@sgi.com> (raw)
Fix for slab corruption caused by alloc_cpumask_var_node() overwriting
the tail end of an off-stack cpumask.
Signed-off-by: Jack Steiner <steiner@sgi.com>
Acked-by: Mike Travis <travis.sgi.com>
---
Corrruption was found in latest linux-next (4/1)
v2.6.29-12081-g421a9f3
lib/cpumask.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux/lib/cpumask.c
===================================================================
--- linux.orig/lib/cpumask.c 2009-04-02 15:30:05.000000000 -0500
+++ linux/lib/cpumask.c 2009-04-02 15:57:44.000000000 -0500
@@ -109,10 +109,10 @@ bool alloc_cpumask_var_node(cpumask_var_
#endif
/* FIXME: Bandaid to save us from old primitives which go to NR_CPUS. */
if (*mask) {
+ unsigned char *ptr = (unsigned char *)cpumask_bits(*mask);
unsigned int tail;
tail = BITS_TO_LONGS(NR_CPUS - nr_cpumask_bits) * sizeof(long);
- memset(cpumask_bits(*mask) + cpumask_size() - tail,
- 0, tail);
+ memset(ptr + cpumask_size() - tail, 0, tail);
}
return *mask != NULL;
next reply other threads:[~2009-04-02 21:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-02 21:27 Jack Steiner [this message]
2009-04-02 21:39 ` [PATCH] - Fix slab corruption caused by alloc_cpumask_var_node() Andrew Morton
2009-04-02 22:09 ` [PATCH] - Updated: " Jack Steiner
2009-04-02 22:23 ` Ingo Molnar
2009-04-02 21:42 ` [PATCH] - " Ingo Molnar
2009-04-05 5:31 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090402212751.GA11495@sgi.com \
--to=steiner@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox