* [PATCH] input: hp_sdc_rtc should depend on serio
@ 2009-04-03 11:16 Alexander Beregalov
2009-04-09 16:35 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Beregalov @ 2009-04-03 11:16 UTC (permalink / raw)
To: dtor, linux-input, linux-kernel
Fix this build error when CONFIG_SERIO is not set
hp_sdc_rtc.c:691: undefined reference to `hp_sdc_request_timer_irq'
and so on..
"select should be used with care. select will force
a symbol to a value without visiting the dependencies."
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
---
drivers/input/misc/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
index 203abac..ae5d7dc 100644
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig
@@ -215,6 +215,7 @@ config INPUT_SGI_BTNS
config HP_SDC_RTC
tristate "HP SDC Real Time Clock"
depends on GSC || HP300
+ select SERIO
select HP_SDC
help
Say Y here if you want to support the built-in real time clock
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] input: hp_sdc_rtc should depend on serio
2009-04-03 11:16 [PATCH] input: hp_sdc_rtc should depend on serio Alexander Beregalov
@ 2009-04-09 16:35 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2009-04-09 16:35 UTC (permalink / raw)
To: Alexander Beregalov; +Cc: linux-input, linux-kernel
Hi Alexander,
On Fri, Apr 03, 2009 at 03:16:21PM +0400, Alexander Beregalov wrote:
> Fix this build error when CONFIG_SERIO is not set
> hp_sdc_rtc.c:691: undefined reference to `hp_sdc_request_timer_irq'
> and so on..
>
> "select should be used with care. select will force
> a symbol to a value without visiting the dependencies."
>
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
> ---
>
> drivers/input/misc/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> index 203abac..ae5d7dc 100644
> --- a/drivers/input/misc/Kconfig
> +++ b/drivers/input/misc/Kconfig
> @@ -215,6 +215,7 @@ config INPUT_SGI_BTNS
> config HP_SDC_RTC
> tristate "HP SDC Real Time Clock"
> depends on GSC || HP300
> + select SERIO
Why don'we make it "depend on SERIO"?
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-09 16:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-03 11:16 [PATCH] input: hp_sdc_rtc should depend on serio Alexander Beregalov
2009-04-09 16:35 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox