From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Greg KH <gregkh@suse.de>,
Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: Commit 7a192ec is build breaking
Date: Sat, 4 Apr 2009 10:44:53 +0100 [thread overview]
Message-ID: <20090404094453.GA11209@flint.arm.linux.org.uk> (raw)
In-Reply-To: <d82e647a0904040018n6e5a261eodcb42d4bb76e65aa@mail.gmail.com>
Note that since I was sending a new set of ARM fixes a couple of days
ago and there didn't seem to be anyone listening to my emails, I fixed
the PXA flash driver myself. Linus now has that fix.
On Sat, Apr 04, 2009 at 03:18:04PM +0800, Ming Lei wrote:
> 2009/4/4 Greg KH <gregkh@suse.de>:
> > On Sat, Mar 28, 2009 at 02:00:49PM +0000, Russell King wrote:
> >> The commit:
> >>
> >> platform driver: fix incorrect use of 'platform_bus_type' with 'struct device_driver'
> >>
> >> contains this:
> >>
> >> -static int __exit pxa2xx_flash_remove(struct device *dev)
> >> +static int __exit pxa2xx_flash_remove(struct platform_device *dev)
> >> ...
> >> - .remove = __exit_p(pxa2xx_flash_remove),
> >> + .remove = __devexit_p(pxa2xx_flash_remove),
> >>
> >> which leads to the following build error:
> >>
> >> `pxa2xx_flash_remove' referenced in section `.data' of drivers/built-in.o: defined in discarded section `.exit.text' of drivers/built-in.o
> >>
> >> This is not the only instance of it in this patch - all __exit_p's
> >> touched by this patch have been converted to __devexit_p's without
> >> regard to the original function.
> >>
> >> Let's revert this change and, if we are going to convert functions
> >> to be __devexit/__devinit, lets have that as a _separate_ patch doing
> >> just that change.
> >
> > Ick, Ming, any thoughts? I'll revert your patch as it looks like it is
> > incorrect in this way.
>
> OK, revert the patch ,please.
> I'll resend a patch to fix incorrect use of 'platform_bus_type' ,
> which does not touch
> __exit_p.
>
> Thanks!
>
> >
> > thanks,
> >
> > greg k-h
> >
>
>
>
> --
> Lei Ming
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2009-04-04 9:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-28 14:00 Commit 7a192ec is build breaking Russell King
2009-04-02 14:57 ` Russell King
2009-04-04 4:17 ` Greg KH
2009-04-04 7:18 ` Ming Lei
2009-04-04 9:44 ` Russell King [this message]
2009-04-04 16:08 ` Greg KH
2009-04-04 16:13 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090404094453.GA11209@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox