Re: Commit 7a192ec is build breaking

Greg KH
2009-04-04T04:18:19Z

On Sat, Mar 28, 2009 at 02:00:49PM +0000, Russell King wrote:
> The commit:
>
> platform driver: fix incorrect use of 'platform_bus_type' with 'struct device_driver'
>
> contains this:
>
> -static int __exit pxa2xx_flash_remove(struct device *dev)
> +static int __exit pxa2xx_flash_remove(struct platform_device *dev)
> ...
> - .remove = __exit_p(pxa2xx_flash_remove),
> + .remove = __devexit_p(pxa2xx_flash_remove),
>
> which leads to the following build error:
>
> `pxa2xx_flash_remove' referenced in section `.data' of drivers/built-in.o: defined in discarded section `.exit.text' of drivers/built-in.o
>
> This is not the only instance of it in this patch - all __exit_p's
> touched by this patch have been converted to __devexit_p's without
> regard to the original function.
>
> Let's revert this change and, if we are going to convert functions
> to be __devexit/__devinit, lets have that as a _separate_ patch doing
> just that change.

Ick, Ming, any thoughts? I'll revert your patch as it looks like it is
incorrect in this way.

thanks,

greg k-h