public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serge@hallyn.com>
To: "Andrew G. Morgan" <morgan@kernel.org>
Cc: "Serge E. Hallyn" <serue@us.ibm.com>,
	linux-security-module@vger.kernel.org,
	lkml <linux-kernel@vger.kernel.org>,
	James Morris <jmorris@namei.org>,
	Casey Schaufler <casey@schaufler-ca.com>
Subject: Re: [PATCH] don't raise all privs on setuid-root file with fE set (v2)
Date: Sat, 4 Apr 2009 22:59:15 -0500	[thread overview]
Message-ID: <20090405035914.GA26896@hallyn.com> (raw)
In-Reply-To: <49D7A11A.8010801@kernel.org>

> Serge E. Hallyn wrote:
> > Distributions face a backward compatibility problem with starting to use
> > file capabilities.  For instance, removing setuid root from ping and
> > doing setcap cap_net_raw=pe means that booting with an older kernel
> > or one compiled without file capabilities means ping won't work for
> > non-root users.
> > 
> > In order to replace the setuid root bit on a capability-unaware
> > program, one has to set the effective, or legacy, file capability,
> > which makes the capability effective immediately.  This patch
> > uses the legacy bit as a queue to not automatically add full
> 
> s/queue/cue/

Oops.

(I wonder whether this is worth resending?)

> > privilege to a setuid-root program.
> > 
> > So, with this patch, an ordinary setuid-root program will run with
> > privilege.  But if /bin/ping has both setuid-root and cap_net_raw in
> > fP and fE, then ping (when run by non-root user) will not run
> > with only cap_net_raw.
> 
> Acked-by: Andrew G. Morgan <morgan@kernel.org>

thanks,
-serge

      reply	other threads:[~2009-04-05  3:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-02 23:47 [PATCH] don't raise all privs on setuid-root file with fE set (v2) Serge E. Hallyn
2009-04-03  1:05 ` James Morris
2009-04-04 18:04 ` Andrew G. Morgan
2009-04-05  3:59   ` Serge E. Hallyn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090405035914.GA26896@hallyn.com \
    --to=serge@hallyn.com \
    --cc=casey@schaufler-ca.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=morgan@kernel.org \
    --cc=serue@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox