From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Tom Zanussi <tzanussi@gmail.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 0/4] [GIT PULL] for tip/tracing/filters
Date: Sun, 5 Apr 2009 16:47:05 +0200 [thread overview]
Message-ID: <20090405144705.GD25250@elte.hu> (raw)
In-Reply-To: <alpine.DEB.2.00.0904041140490.32083@gandalf.stny.rr.com>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> On Sat, 4 Apr 2009, Tom Zanussi wrote:
> > On Fri, 2009-04-03 at 10:36 -0400, Steven Rostedt wrote:
> >
> > I'm guessing the problem is that CONFIG_EVENT_TRACER wasn't selected but
> > should have been, because those tracers all now export events
> > (trace_event_types.h, included by trace_export.c). I'm not sure this is
> > the right way to do it, but the patch below selects EVENT_TRACER if
> > TRACING is selected (a couple of the exported events belong to bprint
> > and print, which don't have a config option other than TRACING, so it
> > seems to belong there).
> >
> > Signed-off-by: Tom Zanussi <tzanussi@gmail.com>
> >
> > ---
> > kernel/trace/Kconfig | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> > index 8a41360..a061746 100644
> > --- a/kernel/trace/Kconfig
> > +++ b/kernel/trace/Kconfig
> > @@ -56,6 +56,7 @@ config TRACING
> > select TRACEPOINTS
> > select NOP_TRACER
> > select BINARY_PRINTF
> > + select EVENT_TRACER
>
> Yeah, we can do this.
Yeah - it has become more of a core facility thing, not a separate
plugin.
That's the long-term healthy life-cycle for certain tracing
functionality anyway: if it becomes so useful that all tracers want
to make use of it, it becomes part of the standard infrastructure.
Ingo
prev parent reply other threads:[~2009-04-05 14:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-02 5:27 [PATCH 0/4] [GIT PULL] for tip/tracing/filters Steven Rostedt
2009-04-02 5:27 ` [PATCH 1/4] tracing/filters: add run-time field descriptions to TRACE_EVENT_FORMAT events Steven Rostedt
2009-04-02 12:17 ` Frederic Weisbecker
2009-04-02 5:27 ` Steven Rostedt
2009-04-02 5:27 ` [PATCH 2/4] tracing/filters: add TRACE_EVENT_FORMAT_NOFILTER event macro Steven Rostedt
2009-04-02 5:27 ` [PATCH 3/4] ring-buffer: add ring_buffer_discard_commit Steven Rostedt
2009-04-02 5:48 ` Andrew Morton
2009-04-02 13:08 ` Steven Rostedt
2009-04-02 5:27 ` [PATCH 4/4] tracing/filters: use ring_buffer_discard_commit for discarded events Steven Rostedt
2009-04-02 9:06 ` Tom Zanussi
2009-04-02 15:01 ` Steven Rostedt
2009-04-03 11:51 ` Ingo Molnar
2009-04-04 1:11 ` Steven Rostedt
2009-04-07 5:46 ` Tom Zanussi
2009-04-07 9:24 ` Steven Rostedt
2009-04-02 5:37 ` [PATCH 0/4] [GIT PULL] for tip/tracing/filters Steven Rostedt
2009-04-03 12:14 ` Ingo Molnar
2009-04-03 14:36 ` Steven Rostedt
2009-04-04 6:50 ` Tom Zanussi
2009-04-04 15:42 ` Steven Rostedt
2009-04-05 7:52 ` Tom Zanussi
2009-04-05 14:47 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090405144705.GD25250@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox