From: Andrew Morton <akpm@linux-foundation.org>
To: "Jeff Haran" <jharan@Brocade.COM>
Cc: <linux-kernel@vger.kernel.org>, Doug Thompson <norsk5@yahoo.com>
Subject: Re: bug in drivers/edac/edac_core.h pci_write_bits32()
Date: Sun, 5 Apr 2009 21:46:19 -0700 [thread overview]
Message-ID: <20090405214619.12611ef4.akpm@linux-foundation.org> (raw)
In-Reply-To: <57AC2FA1761300418C7AB8F3EA493C9702B52DC8@HQ-EXCH-5.corp.brocade.com>
(cc maintainer)
On Thu, 26 Mar 2009 16:54:01 -0700 "Jeff Haran" <jharan@Brocade.COM> wrote:
> 2.6.29 and previous versions seem to contain this bug which I found just
> eyeballing the code:
>
> static inline void pci_write_bits32(struct pci_dev *pdev, int offset,
> u32 value, u32 mask)
> {
> if (mask != 0xffff) {
> u32 buf;
>
> pci_read_config_dword(pdev, offset, &buf);
> value &= mask;
> buf &= ~mask;
> value |= buf;
> }
>
> pci_write_config_dword(pdev, offset, value);
> }
>
> I'm pretty sure that "if" statement should be:
>
> if (mask != 0xffffffff) {
>
> Please copy my email address in any response as I do not subscribe.
>
> Thanks,
prev parent reply other threads:[~2009-04-06 4:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 23:54 bug in drivers/edac/edac_core.h pci_write_bits32() Jeff Haran
2009-04-06 4:46 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090405214619.12611ef4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jharan@Brocade.COM \
--cc=linux-kernel@vger.kernel.org \
--cc=norsk5@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox