public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Alexander Beregalov <a.beregalov@gmail.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org, adobriyan@gmail.com
Subject: Re: [PATCH] Staging: serqt_usb: switch to proc_fops
Date: Sun, 5 Apr 2009 22:29:32 -0700	[thread overview]
Message-ID: <20090406052932.GA19096@kroah.com> (raw)
In-Reply-To: <20090405003748.GA26458@orion>

On Sun, Apr 05, 2009 at 04:37:48AM +0400, Alexander Beregalov wrote:
> Fix this build error:
> serqt_usb.c:441: error: unknown field 'read_proc' specified in initializer
> 
> tty_operations::read_proc was removed in 0f043a81e
> (proc tty: remove struct tty_operations::read_proc)
> 
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>

Thanks for the patch, but I just deleted this function completely, as
it's not needed at all.  The driver needs to be converted to use the
usb-serial layer, not duplicate it, incorrectly, as it currently has
done.  I'm still working on it, that's why it's in the staging tree :)

thanks again,

greg k-h

      reply	other threads:[~2009-04-06  5:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-05  0:37 [PATCH] Staging: serqt_usb: switch to proc_fops Alexander Beregalov
2009-04-06  5:29 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090406052932.GA19096@kroah.com \
    --to=greg@kroah.com \
    --cc=a.beregalov@gmail.com \
    --cc=adobriyan@gmail.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox