Re: [PATCH] drm: ignore LVDS on intel graphics systems that lie about having it

Wang, Zhenyu Z
2009-04-07T01:09:25Z

[-- Attachment #1: Type: text/plain, Size: 2299 bytes --]

On 2009.04.07 00:52:16 +0800, Jesse Barnes wrote:
> On Mon, 6 Apr 2009 10:11:25 -0400
> Jarod Wilson <jarod@redhat.com> wrote:
>
> > There are a number of small form factor desktop systems with Intel
> > mobile graphics chips that lie and say they have an LVDS. With kernel
> > mode-setting, this becomes a problem, and makes native resolution
> > boot go haywire -- for example, my Dell Studio Hybrid, hooked to a
> > 1920x1080 display claims to have a 1024x768 LVDS, and the resulting
> > graphical boot on the 1920x1080 display uses only the top left
> > 1024x768, and auto-configured X will end up only 1024x768 as well.
> > With this change, graphical boot and X both do 1920x1080 as expected.
> >
> > Note that we're simply embracing and extending the early bail-out code
> > in place for the Mac Mini here. The xorg intel driver uses pci
> > subsystem device and vendor id for matching, while we're using dmi
> > lookups here. The MSI addition is courtesy of and tested by Bill
> > Nottingham.
> >
> > One minor issue... Current Fedora rawhide, video playback using Xv
> > makes X go off into the weeds with this patch added, but that's a bug
> > elsewhere, still confident this patch DTRT.
> >
> > Signed-off-by: Jarod Wilson <jarod@redhat.com>
> > Tested-by: Bill Nottingham <notting@redhat.com>
>
> The 2D driver has a similar set of quirks, but since we started that
> list we've found that the VBIOS should contain a pretty reliable table
> indicating which outputs are available, including LVDS. I think if we
> can figure out how to parse it reliably (accounting for VBIOS
> versioning and structure size changes) we shouldn't need this patch.
> If we can't get that done in time for 2.6.30 though I'm all for
> including this.
>
> Zhenyu and Michael does that sound doable?
>

yeah, that's what I tried to fix, instead of adding quirks in KMS,
we try to find a way to detect LVDS config based on VBIOS table.
But looks failed in first round as I haven't got full right info
on VBIOS LVDS config. Old machines might not have correct VBIOS setting,
and I'm not sure about those Intel Mac machines. So this one is fine to me too.

--
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]