From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xsysace: Fix dereferencing of cf_id after hd_driveid removal
Date: Mon, 6 Apr 2009 22:58:10 +0200 [thread overview]
Message-ID: <200904062258.10946.bzolnier@gmail.com> (raw)
In-Reply-To: <20090405083649.1640.31018.stgit@localhost.localdomain>
On Sunday 05 April 2009, Grant Likely wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
>
> Commit 4aaf2fec718f6fbf38668edf733a0ab09a49cab1 (xsysace: make it
> 'struct hd_driveid'-free) converted the cf_id member of 'struct
> ace_device' from a 'struct hd_driveid' to a u16 array. However,
> references to the base of the structure were still using the '&'
> operator. When the address was used with the ata_id_u32() macro, the
> compiler used the size of the entire array instead of sizeof(u16) to
> calculate the offset from the base address.
>
> This patch removes the use of the '&' operator from all references of
> cf_id to fix the bug and remove future confusion.
>
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> CC: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Thanks for quickly spotting & fixing it.
prev parent reply other threads:[~2009-04-06 21:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-05 8:39 [PATCH] xsysace: Fix dereferencing of cf_id after hd_driveid removal Grant Likely
2009-04-06 20:58 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904062258.10946.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox