Re: [PATCH] ramfs: fix double freeing s_fs_info on failed mount

Ingo Molnar
2009-04-07T06:54:09Z

* Wu Fengguang <fengguang.wu@intel.com> wrote:

> From: Ingo Molnar <mingo@elte.hu>
>
> If ramfs mount fails, s_fs_info will be freed twice in
> ramfs_fill_super() and ramfs_kill_sb(), leading to kernel oops.
>
> Consolidate and beautify the code. Make sure s_fs_info and s_root
> are in known good states.
>
> Acked-by: Wu Fengguang <fengguang.wu@intel.com>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>

Nit: the commit is missing a Reported-by :)

Linus might not insist on seeing his name mentioned yet another time
in a commit, but it's generally good practice to always add bug
report info and names.

Note that in this case the really hard work was there: Linus had to
spend at least 2 hours on tracking down and bisecting this bug. (and
Linus probably did this super-fast compared to the average tester -
most other bug reporters spend a day or more on bisection, limited
by lack of practice and by the slowness of kernel builds on ordinary
hardware.)

So the real human effort was spent there, not in my 5 minutes on
fixing the bug that Linus served on a plate - while the commit only
credits me. That's not fair :)

See the tip:out-of-tree local commit i made and sent out.

Ingo