Re: [GIT PULL] SLAB include file dependency fixes + kmemtrace updates

Wu Fengguang
2009-04-07T05:31:20Z

On Tue, Apr 07, 2009 at 12:45:37PM +0800, Linus Torvalds wrote:
>
>
> On Mon, 6 Apr 2009, Linus Torvalds wrote:
> >
> > It bisected past them. I'm getting worried that it's timing-related,
> > because nothing that remains looks even remotely interesting for that Mac
> > mini, but right now:
> >
> > - bad: 56fcef75117a153f298b3fe54af31053f53997dd
> > - good: bb233fdfc7b7cefe45bfa2e8d1b24e79c60a48e5
> >
> > and there's not a whole lot of commits in between.
>
> It's c3b1b1cbf002e65a3cabd479e68b5f35886a26db: 'ramfs: add support for
> "mode=" mount option'.
>
> And I checked. Reverting it at the tip fixes it. So no random timing
> fluctuations.
>
> So that commit causes some random SLAB corruption, that then (depending
> apparently on luck) may or may not crash in some odd random places later.
>
> Wu?

Maybe this bug?

Thanks,
Fengguang
---
ramfs: fix double freeing s_fs_info

On a failed ramfs mount, s_fs_info will be freed twice in ramfs_fill_super()
and ramfs_kill_sb(). Fix it by saving s_fs_info only on success.

Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
diff --git a/fs/ramfs/inode.c b/fs/ramfs/inode.c
index a404fb8..7dbb433 100644
--- a/fs/ramfs/inode.c
+++ b/fs/ramfs/inode.c
@@ -225,7 +225,6 @@ static int ramfs_fill_super(struct super_block * sb, void * data, int silent)
err = -ENOMEM;
goto fail;
}
- sb->s_fs_info = fsi;

err = ramfs_parse_options(data, &fsi->mount_opts);
if (err)
@@ -249,6 +248,7 @@ static int ramfs_fill_super(struct super_block * sb, void * data, int silent)
goto fail;
}
sb->s_root = root;
+ sb->s_fs_info = fsi;
return 0;
fail:
kfree(fsi);