public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: David Rientjes <rientjes@google.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	Brice Goglin <Brice.Goglin@inria.fr>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Yinghai Lu <yhlu.kernel@gmail.com>,
	Chris Worley <worleys@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: Off topic: Numactl "distance" wrong
Date: Tue, 7 Apr 2009 10:23:42 +0200	[thread overview]
Message-ID: <20090407082342.GM17934@one.firstfloor.org> (raw)
In-Reply-To: <alpine.DEB.2.00.0904070058070.20262@chino.kir.corp.google.com>

> If so, that would violate the specification since values 0-9 are reserved.  
> But the validation method still checks and you're not arguing against it, 
> right?  
> 
> slit_valid() is intended to prevent invalid tables from being used because 

No actually it was intended to prevent tables that confuse the scheduler/VM
from being used. At least that is what I wrote it for. The only check
that is really needed is that remote != local, the rest is fluff
admittedly and could be all dropped.

> they are incorrect and, thus, can't possibly be used the describe the 
> physical topology.

As long as the scheduler/VM does roughly the right thing it's ok.

> 
> > In general this thread seems to contain much more speculation than
> > facts.
> > 
> 
> The fact, which you seem to be ignoring, is node hotplug would require 
> this table to change anyway.  It's quite possible using an _SLI method to 
> dynamically reconfigure the localities, including those that were 
> statically described by the BIOS at boot.  So while you may be satisfied 
> with the ACPI 2.0 way of thinking, machines have actually changed in the 
> last five years.

That may be all true in theory, but Linux doesn't implement node hotplug in this
way (not even on architectures like ia64 that would do it in theory) 
In general node hotplug in Linux is pretty useless because you
can only add, never remove, so people don't really use it.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

  reply	other threads:[~2009-04-07  8:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-03 20:02 Off topic: Numactl "distance" wrong Chris Worley
2009-04-03 20:16 ` Brice Goglin
2009-04-03 20:49   ` Yinghai Lu
2009-04-03 21:01     ` Cliff Wickman
2009-04-03 21:43       ` Yinghai Lu
2009-04-03 21:24 ` Andi Kleen
2009-04-03 21:43   ` David Rientjes
2009-04-03 21:48     ` Yinghai Lu
2009-04-03 21:52       ` David Rientjes
2009-04-03 21:55       ` Andi Kleen
2009-04-03 22:15         ` Yinghai Lu
2009-04-07  2:52         ` KOSAKI Motohiro
2009-04-07  6:17           ` Brice Goglin
2009-04-07  7:05             ` Andi Kleen
2009-04-07  7:40               ` Brice Goglin
2009-04-07  7:56                 ` Andi Kleen
2009-04-07  7:44               ` David Rientjes
2009-04-07  7:59                 ` Andi Kleen
2009-04-07  8:08                   ` David Rientjes
2009-04-07  8:23                     ` Andi Kleen [this message]
2009-04-07  8:30                       ` David Rientjes
2009-04-07  9:13                         ` Andi Kleen
2009-04-03 21:53     ` Andi Kleen
2009-04-03 21:54       ` David Rientjes
2009-04-03 22:18         ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090407082342.GM17934@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=Brice.Goglin@inria.fr \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rientjes@google.com \
    --cc=worleys@gmail.com \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox