Re: [PATCH 13/13] DRBD: final

Sam Ravnborg
2009-03-30T19:03:52Z

> +#
> +config BLK_DEV_DRBD
> + tristate "DRBD Distributed Replicated Block Device support"
> + select INET
> + select PROC_FS
> + select CONNECTOR
> + select CRYPTO
> + select CRYPTO_HMAC

Have you double checked that these symbols are supposed to be 'selected'?
If they:
- have dependencies
- have a prompt
then they most likely are not.

> @@ -0,0 +1,7 @@
> +#CFLAGS_drbd_sizeof_sanity_check.o = -Wpadded # -Werror
Commented out?

> +
> +drbd-objs := drbd_buildtag.o drbd_bitmap.o drbd_proc.o \
> + drbd_worker.o drbd_receiver.o drbd_req.o drbd_actlog.o \
> + lru_cache.o drbd_main.o drbd_strings.o drbd_nl.o

Please use:
drdb-y := drbd_buildtag.o drbd_bitmap.o drbd_proc.o
...

And my personal taste favours:
drdb-y := ...
drdb-y += ...

over all the escaping.

Sam