The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Nico Schottelius <nico-linux-20090330@schottelius.org>,
	LKML <linux-kernel@vger.kernel.org>,
	trivial@kernel.org
Subject: Re: [Resend] [PATCH] Fix scripts/setlocalversion with git
Date: Tue, 7 Apr 2009 19:45:50 +0200	[thread overview]
Message-ID: <20090407174550.GB13089@uranus.ravnborg.org> (raw)
In-Reply-To: <alpine.LNX.2.00.0904071755540.5327@wotan.suse.de>

On Tue, Apr 07, 2009 at 05:56:31PM +0200, Jiri Kosina wrote:
> On Tue, 7 Apr 2009, Nico Schottelius wrote:
> 
> > Hello again!
> > 
> > I just saw that this patch did not go anywhere and did not have
> > any replies, so I repost it.
> > 
> > I also created a git-repo at
> >   
> >   git://git.schottelius.org/linux/linux-2.6
> >   gitweb:
> >   http://git.schottelius.org/?p=linux/linux-2.6;a=summary
> > 
> > if you want the patch (f43ba0be1204e7c26cc700a75bdb688a788fbf2f)
> > via git.
> > 
> > Sincerly,
> > 
> > Nico
> > 
> > Nico Schottelius [Mon, Mar 30, 2009 at 02:21:37PM +0200]:
> > > Hello!
> > > 
> > > When using trees like wireless-testing, which have untagged tags,
> > > scripts/setlocalversion does not display any git indication for
> > > localversion.
> > > 
> > > This patch fixes it: If git is available, but no usable tag is found,
> > > it uses -g${head}. It skips the detection of unanottated tags via
> > > git name-rev.
> > > 
> > > Please apply, otherwise testers like me always have '2.6.29' for trees
> > > with unanottated tags, instead of 2.6.29-20318-g9aa4755, which helps
> > > a lot if you've tons of kernels installed from different trees.
> 
> This patch isn't trivial enough to be applicable through trivial tree. 
> Adding Sam to CC.

Thanks. Will take care later this week.

	Sam

  reply	other threads:[~2009-04-07 17:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-30 12:21 [PATCH] Fix scripts/setlocalversion with git Nico Schottelius
2009-04-07 15:44 ` [Resend] " Nico Schottelius
2009-04-07 15:56   ` Jiri Kosina
2009-04-07 17:45     ` Sam Ravnborg [this message]
2009-04-17 21:34       ` Nico Schottelius
2009-04-17 21:58         ` Sam Ravnborg
2009-04-18  9:16           ` Nico Schottelius
2009-04-25  7:50             ` Sam Ravnborg
2009-04-25 12:24               ` Nico Schottelius

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090407174550.GB13089@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nico-linux-20090330@schottelius.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox