From: Ingo Molnar <mingo@elte.hu>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Christian Pellegrin <chripell@gmail.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: [-rc1, build bug] Re: [PATCH 05/11] Add support for the MAX3100 SPI UART.
Date: Wed, 8 Apr 2009 08:18:11 +0200 [thread overview]
Message-ID: <20090408061811.GA22767@elte.hu> (raw)
In-Reply-To: <20090407154840.18020.82549.stgit@t61.ukuu.org.uk>
* Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> From: Christian Pellegrin <chripell@gmail.com>
>
> (akpm: queued pending confirmation of the new major number)
>
> [randy.dunlap@oracle.com: select SERIAL_CORE]
> Signed-off-by: Christian Pellegrin <chripell@fsfe.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
> ---
>
> drivers/serial/Kconfig | 7 +++++++
> drivers/serial/Makefile | 1 +
> include/linux/serial_core.h | 3 +++
> 3 files changed, 11 insertions(+), 0 deletions(-)
This is now upstream as:
1dcb884: Add support for the MAX3100 SPI UART.
i'm not sure whether it has been reported already, but the new
driver does not even build:
CHK include/linux/compile.h
make[2]: *** No rule to make target `drivers/serial/max3100.o', needed by `drivers/serial/built-in.o'. Stop.
make[1]: *** [drivers/serial] Error 2
make[1]: *** Waiting for unfinished jobs....
... and it has no chance to build, because the commit adds no
max3100.c driver file, at all.
The straight revert of 1dcb884 got the build going.
Ingo
next prev parent reply other threads:[~2009-04-08 6:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 15:47 [PATCH 00/11] Second serial updates (please discard previous) Alan Cox
2009-04-07 15:48 ` [PATCH 01/11] tty: Correct inline types for tty_driver_kref_get() Alan Cox
2009-04-07 15:48 ` [PATCH 02/11] tty: Use the generic RS485 ioctl on CRIS Alan Cox
2009-04-07 15:48 ` [PATCH 03/11] serqt: initial clean up pass for tty side Alan Cox
2009-04-07 15:48 ` [PATCH 04/11] lanana: assign a device name and numbering for MAX3100 Alan Cox
2009-04-07 15:48 ` [PATCH 05/11] Add support for the MAX3100 SPI UART Alan Cox
2009-04-08 6:18 ` Ingo Molnar [this message]
2009-04-08 6:34 ` [-rc1, build bug] " chripell
2009-04-08 6:45 ` Yang Hongyang
2009-04-08 10:24 ` Alan Cox
2009-04-08 10:31 ` David Miller
2009-04-07 15:51 ` [PATCH 06/11] Change hardware flow control from poll to interrupt driven Alan Cox
2009-04-07 15:52 ` [PATCH 07/11] tty: Blackin CTS/RTS Alan Cox
2009-04-07 15:52 ` [PATCH 08/11] Change KCONFIG name Alan Cox
2009-04-07 15:52 ` [PATCH 09/11] KGDB_SERIAL_CONSOLE check for module Alan Cox
2009-04-07 15:53 ` [PATCH 10/11] Adjust path to gpio headers Alan Cox
2009-04-07 15:53 ` [PATCH 11/11] tty: jsm cleanups Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090408061811.GA22767@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=chripell@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox