From: Ingo Molnar <mingo@elte.hu>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: mingo@redhat.com, hpa@zytor.com, acme@redhat.com,
linux-kernel@vger.kernel.org, alan.brunelle@hp.com,
jens.axboe@oracle.com, tglx@linutronix.de,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:tracing/blktrace-v2] blktrace: fix a bug in blk_msg_write()
Date: Wed, 8 Apr 2009 11:04:53 +0200 [thread overview]
Message-ID: <20090408090453.GC12283@elte.hu> (raw)
In-Reply-To: <49DBFEB0.9080308@cn.fujitsu.com>
* Li Zefan <lizf@cn.fujitsu.com> wrote:
> Hi Ingo,
>
> Though Carl <chlunde@ping.uio.no>'s patch has been applied,
> (a4b3ada83d06554d307dd54abdc62b2e5648264a), this patch hasn't
> been dropped, thus the code in -tip looks like:
>
> static ssize_t blk_msg_write(...)
> {
> ...
> if (copy_from_user(msg, buffer, count)) {
> kfree(msg);
> return -EFAULT;
> }
> msg[count] = '\0'; <---
>
> msg[count] = '\0'; <---
> ...
> }
indeed - that's a (harmless) merge artifact in tip/master, it has
not propagated into the tracing topics and will go away on the next
reintegration.
Thanks for letting me know, i'll keep an eye on it.
Ingo
prev parent reply other threads:[~2009-04-08 9:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-03 7:31 [PATCH] blktrace: fix a bug in blk_msg_write() Li Zefan
2009-04-03 11:17 ` Ingo Molnar
2009-04-03 12:27 ` Jens Axboe
2009-04-03 12:51 ` [tip:tracing/blktrace-v2] blktrace: NUL-terminate user space messages Carl Henrik Lunde
2009-04-03 12:52 ` [PATCH] blktrace: fix a bug in blk_msg_write() Ingo Molnar
2009-04-03 12:59 ` Ingo Molnar
2009-04-03 13:03 ` Jens Axboe
2009-04-03 12:51 ` [tip:tracing/blktrace-v2] blktrace: small cleanup " Li Zefan
[not found] ` <tip-48cefde3c17bbf37fee99e2889bcc718e5805dfa@git.kernel.org>
2009-04-08 1:32 ` [tip:tracing/blktrace-v2] blktrace: fix a bug " Li Zefan
2009-04-08 9:04 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090408090453.GC12283@elte.hu \
--to=mingo@elte.hu \
--cc=acme@redhat.com \
--cc=alan.brunelle@hp.com \
--cc=hpa@zytor.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox