public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Tom Zanussi <tzanussi@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	fweisbec@gmail.com
Subject: Re: [PATCH] tracing/filters: use ring_buffer_discard_commit() in filter_check_discard()
Date: Wed, 8 Apr 2009 11:22:24 +0200	[thread overview]
Message-ID: <20090408092224.GD12283@elte.hu> (raw)
In-Reply-To: <1239178441.10295.34.camel@tropicana>


* Tom Zanussi <tzanussi@gmail.com> wrote:

> As for the other errors, it's the CONFIG_EVENT_TRACER not being 
> turned on again.  I think the tracing config patch below would be 
> a better solution than the one I previously posted...

Agreed, this is a very nice patch, i have applied it. I'll check 
whether this solves all the build problems.

This fits nicely into the 'tracing plugin life cycle' and basically 
this is what we want to see happen for ftrace plugins: they first 
start as standalone experiments. Once they prove to be useful and 
other tracer plugins desire its capabilities too, they become part 
of the tracing infrastructure, not part of a standalone plugin.

This gives some leeway in allowing people to do plugins even if 
plugin utility is not immediately obvious, and we can then observe 
its use and let features/capabilities percolate down into the core 
code.

There's also plugin functionality that works best when left 
standalone - they are specifically shaped for one very particular 
development activity: for example mmiotrace to debug drivers.

It's a bit like how Firefox developers manage their plugin space, 
and this concept seems to have worked well in a number of cases in 
the tracing tree too.

	Ingo

  reply	other threads:[~2009-04-08  9:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-07  5:50 [PATCH] tracing/filters: use ring_buffer_discard_commit() in filter_check_discard() Tom Zanussi
2009-04-07 13:08 ` Ingo Molnar
2009-04-08  8:14   ` Tom Zanussi
2009-04-08  9:22     ` Ingo Molnar [this message]
2009-04-08 11:11     ` Frederic Weisbecker
2009-04-13 22:23     ` [tip:tracing/core] tracing/infrastructure: separate event tracer from event support tip-bot for Tom Zanussi
2009-04-14  2:37       ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090408092224.GD12283@elte.hu \
    --to=mingo@elte.hu \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox