From: Ingo Molnar <mingo@elte.hu>
To: Mahesh Jagannath Salgaonkar <mahesh@linux.vnet.ibm.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Suresh B Siddha <suresh.b.siddha@intel.com>,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
svaidy@linux.vnet.ibm.com, balbir@linux.vnet.ibm.com,
dipankar@in.ibm.com, Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] Don't export sched_mc_power_savings on multi-socket single core system
Date: Wed, 8 Apr 2009 13:42:03 +0200 [thread overview]
Message-ID: <20090408114203.GA30441@elte.hu> (raw)
In-Reply-To: <49DC89A3.3090605@linux.vnet.ibm.com>
* Mahesh Jagannath Salgaonkar <mahesh@linux.vnet.ibm.com> wrote:
> Fix to prevent sched_mc_power_saving from being exported through
> sysfs for multi-scoket single core system. Max cores should be
> always greater than one (1). My earlier patch that introduced fix
> for not exporting 'sched_mc_power_saving' on laptops broke it on
> multi-socket single core system. This fix addresses issue on both
> laptop and multi-socket single core system. Below are the Test
> results:
> +#define mc_capable() (boot_cpu_data.x86_max_cores > 1) && \
> + (cpumask_weight(cpu_core_mask(0)) != nr_cpu_ids)
> #define smt_capable() (smp_num_siblings > 1)
patch looks good but is whitespace damaged (all tabs were converted
to spaces). See Documentation/email-clients.txt about how to set up
your client.
Ingo
prev parent reply other threads:[~2009-04-08 12:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-08 11:25 [PATCH] Don't export sched_mc_power_savings on multi-socket single core system Mahesh Jagannath Salgaonkar
2009-04-08 11:42 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090408114203.GA30441@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=balbir@linux.vnet.ibm.com \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=suresh.b.siddha@intel.com \
--cc=svaidy@linux.vnet.ibm.com \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox