From: Ingo Molnar <mingo@elte.hu>
To: Cyrill Gorcunov <gorcunov@openvz.org>, Yinghai Lu <yinghai@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>,
Suresh Siddha <suresh.b.siddha@intel.com>
Subject: Re: [PATCH -tip] x86: do_IRQ - send EOI for x86-32 on irq without handler
Date: Wed, 8 Apr 2009 15:25:58 +0200 [thread overview]
Message-ID: <20090408132558.GA1141@elte.hu> (raw)
In-Reply-To: <20090408130217.GL18581@elte.hu>
* Ingo Molnar <mingo@elte.hu> wrote:
>
> * Cyrill Gorcunov <gorcunov@openvz.org> wrote:
>
> > For X86-32 if IRQ has no handler it remains non-Ack'ed
> > even if APIC is not requested for being disabled.
> > Fix it.
>
> nice fix. Did you observe any real hangs in such a situation, or is
> this via code review?
more stuff needs fixing here first:
arch/x86/kernel/irq.c: In function ‘do_IRQ’:
arch/x86/kernel/irq.c:226: error: ‘disable_apic’ undeclared (first use in this function)
arch/x86/kernel/irq.c:226: error: (Each undeclared identifier is reported only once
arch/x86/kernel/irq.c:226: error: for each function it appears in.)
like making 'disable_apic' available everywhere.
Or better yet: introduce a dummy apic->write() method in the
disable_apic=1 case so we can call a straight ack_APIC_irq().
Ingo
next prev parent reply other threads:[~2009-04-08 13:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-03 18:57 [PATCH -tip] x86: do_IRQ - send EOI for x86-32 on irq without handler Cyrill Gorcunov
2009-04-08 13:02 ` Ingo Molnar
2009-04-08 13:25 ` Ingo Molnar [this message]
2009-04-08 13:57 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090408132558.GA1141@elte.hu \
--to=mingo@elte.hu \
--cc=gorcunov@openvz.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox