Re: [PATCH] Fix broken compilation of Cris serial driver

Alexey Dobriyan
2009-04-08T12:51:35Z

On Wed, Apr 08, 2009 at 12:57:01PM +0200, Jesper Nilsson wrote:
> On Wed, Apr 08, 2009 at 12:07:16PM +0200, Claudio Scordino wrote:
> > compilation of cris serial driver on 2.6.30-rc1 is broken since
> > commit number 0f043a81ebe84be3576667f04fdda481609e3816 removed the
> > read_proc field from the tty_driver structure.
> >
> > The patch in attachment may fix the problem. Please check it very
> > carefully: I don't have hardware to make any test.

> > - .read_proc = rs_read_proc,
> > .tiocmget = rs_tiocmget,
> > .tiocmset = rs_tiocmset
> > };
> > @@ -4490,6 +4490,7 @@ rs_init(void)
> > if (tty_register_driver(driver))
> > panic("Couldn't register serial driver\n");
> > /* do some initializing for the separate ports */
> > + driver->proc_entry->read_proc = rs_read_proc;
>
> Is this the recommended way to convert proc handling?

No.

> I find no other serial driver that does it this way...

->read_proc effectively went away.

> I was looking at using the proc_fops instead, but that is a
> much larger change.
>
> I will try to test your patch and if it works I'll push it
> through the CRIS tree.

It shouldn't work, ->read_proc won't even be called.