Re: [PATCH] Fix broken compilation of Cris serial driver

Jesper Nilsson
2009-04-08T14:01:50Z

On Wed, Apr 08, 2009 at 02:51:22PM +0200, Alexey Dobriyan wrote:
> On Wed, Apr 08, 2009 at 12:57:01PM +0200, Jesper Nilsson wrote:
> > On Wed, Apr 08, 2009 at 12:07:16PM +0200, Claudio Scordino wrote:
> > > compilation of cris serial driver on 2.6.30-rc1 is broken since
> > > commit number 0f043a81ebe84be3576667f04fdda481609e3816 removed the
> > > read_proc field from the tty_driver structure.
> > >
> > > The patch in attachment may fix the problem. Please check it very
> > > carefully: I don't have hardware to make any test.
>
> > > - .read_proc = rs_read_proc,
> > > .tiocmget = rs_tiocmget,
> > > .tiocmset = rs_tiocmset
> > > };
> > > @@ -4490,6 +4490,7 @@ rs_init(void)
> > > if (tty_register_driver(driver))
> > > panic("Couldn't register serial driver\n");
> > > /* do some initializing for the separate ports */
> > > + driver->proc_entry->read_proc = rs_read_proc;
> >
> > Is this the recommended way to convert proc handling?
>
> No.

Ok, that's what I thought.

> > I find no other serial driver that does it this way...
>
> ->read_proc effectively went away.

...so what do we use as a replacement, is it .proc_fops
or anything else?

/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com