From: Andrew Morton <akpm@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86,edac: fix for compiler error in traps.c
Date: Wed, 8 Apr 2009 17:52:28 -0700 [thread overview]
Message-ID: <20090408175228.51ecc517.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.2.00.0904082004070.16430@gandalf.stny.rr.com>
On Wed, 8 Apr 2009 20:06:53 -0400 (EDT) Steven Rostedt <rostedt@goodmis.org> wrote:
>
> Impact: compile fix
>
> I got this compile failure on both tip/tracing/core as well as on
> v2.6.30-rc1.
>
> LD .tmp_vmlinux1
> arch/x86/kernel/built-in.o: In function `do_nmi':
> (.text+0x3c18): undefined reference to `edac_handler_set'
> arch/x86/kernel/built-in.o: In function `do_nmi':
> (.text+0x3c48): undefined reference to `edac_atomic_assert_error'
> make: *** [.tmp_vmlinux1] Error 1
> [root@bxrhel51 linux-trace.git]# grep edac_handler_set
> [root@bxrhel51 linux-trace.git]# Grep edac_handler_set '*.[ch]'
> find . -name "*.[ch]" ! -type d | xargs grep "edac_handler_set"
> ./arch/x86/kernel/traps.c: if (edac_handler_set()) {
> ./include/linux/edac.h:extern int edac_handler_set(void);
> ./drivers/edac/edac_stub.c:int edac_handler_set(void)
> ./drivers/edac/edac_stub.c:EXPORT_SYMBOL_GPL(edac_handler_set);
>
> This patch seems to fix it.
>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
>
> diff --git a/drivers/edac/Makefile b/drivers/edac/Makefile
> index a5fdcf0..cc2bcb4 100644
> --- a/drivers/edac/Makefile
> +++ b/drivers/edac/Makefile
> @@ -7,7 +7,7 @@
> #
>
>
> -obj-$(CONFIG_EDAC) := edac_stub.o
> +obj-$(CONFIG_EDAC) += edac_stub.o
> obj-$(CONFIG_EDAC_MM_EDAC) += edac_core.o
>
> edac_core-objs := edac_mc.o edac_device.o edac_mc_sysfs.o edac_pci_sysfs.o
Confused. Why didn't 2.6.29 break?
next prev parent reply other threads:[~2009-04-09 0:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.DEB.2.00.0904081954530.16430@gandalf.stny.rr.com>
2009-04-09 0:06 ` [PATCH] x86,edac: fix for compiler error in traps.c Steven Rostedt
2009-04-09 0:48 ` Andrew Morton
2009-04-09 15:07 ` Steven Rostedt
2009-04-09 0:52 ` Andrew Morton [this message]
2009-04-09 3:58 ` Ingo Molnar
2009-04-09 14:51 ` Steven Rostedt
2009-04-09 18:41 Doug Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090408175228.51ecc517.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox