From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Yinghai Lu <yhlu.kernel@gmail.com>
Subject: [PATCH -tip] x86: do_IRQ - send EOI for x86-32 on irq without handler v3
Date: Wed, 8 Apr 2009 23:36:56 +0400 [thread overview]
Message-ID: <20090408193656.GI7556@lenovo> (raw)
For X86-32 if IRQ has no handler it remains non-Ack'ed
even if APIC is not requested for being disabled.
Since disable_apic depends on CONFIG_X86_LOCAL_APIC rather
then CONFIG_X86_64 we could bring tiny fix here.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
---
arch/x86/kernel/irq.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
Ingo it's an interim fix.
I didn't manage yet to implement what you proposed
(marked http://lkml.org/lkml/2009/4/8/549).
Index: linux-2.6.git/arch/x86/kernel/irq.c
=====================================================================
--- linux-2.6.git.orig/arch/x86/kernel/irq.c
+++ linux-2.6.git/arch/x86/kernel/irq.c
@@ -223,10 +223,16 @@ unsigned int __irq_entry do_IRQ(struct p
irq = __get_cpu_var(vector_irq)[vector];
if (!handle_irq(irq, regs)) {
-#ifdef CONFIG_X86_64
+ /*
+ * FIXME: Actually we could go further and replace
+ * ack_APIC_irq->apic_write->apic->write with a NOP
+ * operation as only disable_apic is set and happily call
+ * ack_APIC_irq after that without any tests
+ */
+#ifdef CONFIG_X86_LOCAL_APIC
if (!disable_apic)
- ack_APIC_irq();
#endif
+ ack_APIC_irq();
if (printk_ratelimit())
printk(KERN_EMERG "%s: %d.%d No irq handler for vector (irq %d)\n",
reply other threads:[~2009-04-08 19:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090408193656.GI7556@lenovo \
--to=gorcunov@openvz.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox