From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: [PATCH 1/4] perf_counter: fix off-by-one on the string lengths
Date: Thu, 09 Apr 2009 10:53:43 +0200 [thread overview]
Message-ID: <20090409085524.338620360@chello.nl> (raw)
In-Reply-To: 20090409085342.799915215@chello.nl
[-- Attachment #1: perf_counter-fix-strings.patch --]
[-- Type: text/plain, Size: 891 bytes --]
strlen() does _not_ include the terminating \0.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
kernel/perf_counter.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6/kernel/perf_counter.c
===================================================================
--- linux-2.6.orig/kernel/perf_counter.c
+++ linux-2.6/kernel/perf_counter.c
@@ -1989,7 +1989,7 @@ static void perf_counter_comm_event(stru
unsigned int size;
char *comm = comm_event->task->comm;
- size = ALIGN(strlen(comm), sizeof(u64));
+ size = ALIGN(strlen(comm)+1, sizeof(u64));
comm_event->comm = comm;
comm_event->comm_size = size;
@@ -2109,7 +2109,7 @@ static void perf_counter_mmap_event(stru
}
got_name:
- size = ALIGN(strlen(name), sizeof(u64));
+ size = ALIGN(strlen(name)+1, sizeof(u64));
mmap_event->file_name = name;
mmap_event->file_size = size;
--
next prev parent reply other threads:[~2009-04-09 8:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 8:53 [PATCH 0/4] perf_counter: fixes and an optimization Peter Zijlstra
2009-04-09 8:53 ` Peter Zijlstra [this message]
2009-04-09 8:53 ` [PATCH 2/4] perf_counter: optimize mmap/comm tracking Peter Zijlstra
2009-04-09 9:06 ` [tip:perfcounters/core] " Peter Zijlstra
2009-04-09 9:16 ` [PATCH 2/4] " Ingo Molnar
2009-04-09 9:28 ` Peter Zijlstra
2009-04-09 9:54 ` [tip:perfcounters/core] " Peter Zijlstra
2009-04-09 8:53 ` [PATCH 3/4] perf_counter: sysctl for system wide perf counters Peter Zijlstra
2009-04-09 9:06 ` [tip:perfcounters/core] " Peter Zijlstra
2009-04-09 9:54 ` Peter Zijlstra
2009-04-09 8:53 ` [PATCH 4/4] perf_counter: log full path names Peter Zijlstra
2009-04-09 9:07 ` [tip:perfcounters/core] " Peter Zijlstra
2009-04-09 9:54 ` Peter Zijlstra
2009-04-09 9:03 ` [PATCH 0/4] perf_counter: fixes and an optimization Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090409085524.338620360@chello.nl \
--to=a.p.zijlstra@chello.nl \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox