From: Andreas Herrmann <andreas.herrmann3@amd.com>
To: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Mark Langsdorf <mark.langsdorf@amd.com>
Subject: [PATCH 3/8] x86: cacheinfo: use L3 cache index disable feature only for CPUs that support it
Date: Thu, 9 Apr 2009 15:05:10 +0200 [thread overview]
Message-ID: <20090409130510.GG31527@alberich.amd.com> (raw)
In-Reply-To: <20090409125659.GD31527@alberich.amd.com>
AMD family 0x11 CPU doesn't support the feature.
Some AMD family 0x10 CPUs do not support it or have an erratum, see
erratum #382 in "Revision Guide for AMD Family 10h Processors, 41322
Rev. 3.40 February 2009".
CC: Mark Langsdorf <mark.langsdorf@amd.com>
Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
---
arch/x86/kernel/cpu/intel_cacheinfo.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/cpu/intel_cacheinfo.c b/arch/x86/kernel/cpu/intel_cacheinfo.c
index c471eb1..3973506 100644
--- a/arch/x86/kernel/cpu/intel_cacheinfo.c
+++ b/arch/x86/kernel/cpu/intel_cacheinfo.c
@@ -291,6 +291,14 @@ amd_check_l3_disable(int index, struct _cpuid4_info_regs *this_leaf)
{
if (index < 3)
return;
+
+ if (boot_cpu_data.x86 == 0x11)
+ return;
+
+ /* see erratum #382 */
+ if ((boot_cpu_data.x86 == 0x10) && (boot_cpu_data.x86_model < 0x8))
+ return;
+
this_leaf->can_disable = 1;
}
--
1.6.2
next prev parent reply other threads:[~2009-04-09 13:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 12:56 [PATCH 0/8] x86: cacheinfo: cache_disable fixes/cleanup Andreas Herrmann
2009-04-09 12:59 ` [PATCH 1/8] Revert "x86, cpu: intel_cacheinfo.c: use cpumask_first(to_cpumask())" Andreas Herrmann
2009-04-09 13:02 ` [PATCH 2/8] Revert "x86, cpu: conform L3 Cache Index Disable to Linux standards" Andreas Herrmann
2009-04-09 13:05 ` Andreas Herrmann [this message]
2009-04-10 12:36 ` [tip:x86/cpu] x86: cacheinfo: use L3 cache index disable feature only for CPUs that support it Andreas Herrmann
2009-04-09 13:07 ` [PATCH 4/8] x86: cacheinfo: correct return value when cache_disable feature is not active Andreas Herrmann
2009-04-10 12:36 ` [tip:x86/cpu] " Andreas Herrmann
2009-04-09 13:16 ` [PATCH 5/8] x86: cacheinfo: use cached K8 NB_MISC devices instead of scanning for it Andreas Herrmann
2009-04-10 12:36 ` [tip:x86/cpu] " Andreas Herrmann
2009-04-09 13:18 ` [PATCH 6/8] x86: cacheinfo: replace sysfs interface for cache_disable feature Andreas Herrmann
2009-04-10 12:37 ` [tip:x86/cpu] " Mark Langsdorf
2009-04-13 4:52 ` Jaswinder Singh Rajput
2009-04-13 4:56 ` Jaswinder Singh Rajput
2009-04-14 11:58 ` Ingo Molnar
2009-04-14 12:48 ` Jaswinder Singh Rajput
2009-04-14 13:28 ` Ingo Molnar
2009-04-09 13:24 ` [PATCH 7/8] x86: cacheinfo: disable L3 ECC scrubbing when L3 cache index is disabled Andreas Herrmann
2009-04-10 12:37 ` [tip:x86/cpu] " Mark Langsdorf
2009-04-09 13:31 ` [PATCH 8/8] x86/docs: add description for cache_disable sysfs interface Andreas Herrmann
2009-04-10 12:37 ` [tip:x86/cpu] " Mark Langsdorf
2009-04-10 12:28 ` [PATCH 0/8] x86: cacheinfo: cache_disable fixes/cleanup Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090409130510.GG31527@alberich.amd.com \
--to=andreas.herrmann3@amd.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@amd.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox