Re: [PATCH] x86: cacheinfo: complete L2/L3 Cache and TLB associativity field definitions

Andreas Herrmann
2009-04-03T10:31:39Z

On Thu, Apr 02, 2009 at 12:30:08PM +0200, Ingo Molnar wrote:
>
> * Andreas Herrmann <andreas.herrmann3@amd.com> wrote:
>
> > Impact: complete cache information for AMD CPUs
> >
> > See "CPUID Specification" (AMD Publication #: 25481, Rev. 2.28, April 2008)
> >
> > Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
> > ---
> > arch/x86/kernel/cpu/intel_cacheinfo.c | 16 ++++++++++++----
> > 1 files changed, 12 insertions(+), 4 deletions(-)
> >
> > Please apply.
>
> Hm, the x86/cpu topic is marked broken and blocked by another AMD
> patch from Mark Langsdorf:
>
> 45ca863: x86, cpu: conform L3 Cache Index Disable to Linux standards

Oops, wasn't aware that you had applied this patch and I couldn't find
it in tip/master. Now I know why.

The code seems broken. Defining k8_northbridges in a header file is the
wrong thing to do. I'll look at it.

Andreas

--
Operating | Advanced Micro Devices GmbH
System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
Research | Geschäftsführer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni
Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
(OSRC) | Registergericht München, HRB Nr. 43632