From: Andrew Morton <akpm@linux-foundation.org>
To: Alexander Beregalov <a.beregalov@gmail.com>
Cc: jeffm@suse.com, reiserfs-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reiserfs: fix printk format warning
Date: Thu, 9 Apr 2009 13:58:03 -0700 [thread overview]
Message-ID: <20090409135803.2c011dee.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090403013437.GA29003@orion>
On Fri, 3 Apr 2009 05:34:37 +0400
Alexander Beregalov <a.beregalov@gmail.com> wrote:
> Fix following warning message
> fs/reiserfs/procfs.c:393: warning: format '%u' expects type 'unsigned int', but argument 22 has type 'long unsigned int'
> introduced in 600ed4167
> (reiserfs: audit transaction ids to always be unsigned ints)
>
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
> ---
>
> include/linux/reiserfs_fs_sb.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/reiserfs_fs_sb.h b/include/linux/reiserfs_fs_sb.h
> index 5621d87..1d1594a 100644
> --- a/include/linux/reiserfs_fs_sb.h
> +++ b/include/linux/reiserfs_fs_sb.h
> @@ -193,7 +193,7 @@ struct reiserfs_journal {
> atomic_t j_wcount; /* count of writers for current commit */
> unsigned long j_bcount; /* batch count. allows turning X transactions into 1 */
> unsigned long j_first_unflushed_offset; /* first unflushed transactions offset */
> - unsigned long j_last_flush_trans_id; /* last fully flushed journal timestamp */
> + unsigned int j_last_flush_trans_id; /* last fully flushed journal timestamp */
> struct buffer_head *j_header_bh;
>
> time_t j_trans_start_time; /* time this transaction started */
Yes, looking at the code I think it does want to be a u32.
prev parent reply other threads:[~2009-04-09 21:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-03 1:34 [PATCH] reiserfs: fix printk format warning Alexander Beregalov
2009-04-09 20:58 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090409135803.2c011dee.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.beregalov@gmail.com \
--cc=jeffm@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox